Added options to simple() method

ivancea · ivancea · commit 417854721ae4 · 2025-05-09T12:03:14.000+02:00
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/aggregation/GroupingAggregatorFunctionTestCase.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/aggregation/GroupingAggregatorFunctionTestCase.java
@@ -38,7 +38,6 @@
 import org.elasticsearch.compute.operator.SourceOperator;
 import org.elasticsearch.compute.test.BlockTestUtils;
 import org.elasticsearch.compute.test.CannedSourceOperator;
-import org.elasticsearch.compute.test.OperatorTestCase;
 import org.elasticsearch.compute.test.TestBlockFactory;
 import org.elasticsearch.core.Nullable;
 import org.elasticsearch.core.Releasables;
@@ -47,7 +46,6 @@
 import org.hamcrest.Matcher;
 
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.List;
 import java.util.SortedSet;
 import java.util.TreeSet;
@@ -130,23 +128,6 @@ private Operator.OperatorFactory simpleWithMode(
         }
     }
 
-    /**
-     * Checks whether the class is being run by {@link org.elasticsearch.compute.test.OperatorTestCase#testSimpleCircuitBreaking} or not.
-     * <p>
-     *     If it is, then we can't randomize blocks, as it expects a deterministic memory usage.
-     * </p>
-     * <p>
-     *     Explicitly linking {@link org.elasticsearch.compute.test.OperatorTestCase#testSimpleCircuitBreaking} as
-     *     this method looks for it based on its name, so any modification there should be updated here!
-     * </p>
-     */
-    private boolean shouldRandomizeBlocks() {
-        return Arrays.stream(Thread.currentThread().getStackTrace())
-            .noneMatch(
-                e -> e.getClassName().equals(OperatorTestCase.class.getName()) && e.getMethodName().equals("testSimpleCircuitBreaking")
-            );
-    }
-
     @Override
     protected final Matcher<String> expectedDescriptionOfSimple() {
         return equalTo("HashAggregationOperator[mode = <not-needed>, aggs = " + expectedDescriptionOfAggregator() + "]");
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneCountOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneCountOperatorTests.java
@@ -51,7 +51,7 @@ public void closeIndex() throws IOException {
     }
 
     @Override
-    protected LuceneCountOperator.Factory simple() {
+    protected LuceneCountOperator.Factory simple(SimpleOptions options) {
         return simple(randomFrom(DataPartitioning.values()), between(1, 10_000), 100);
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneMaxOperatorTestCase.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneMaxOperatorTestCase.java
@@ -73,7 +73,7 @@ public void closeIndex() throws IOException {
     }
 
     @Override
-    protected LuceneMaxFactory simple() {
+    protected LuceneMaxFactory simple(SimpleOptions options) {
         return simple(getNumberTypeTest(), randomFrom(DataPartitioning.values()), between(1, 10_000), 100);
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneMinOperatorTestCase.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneMinOperatorTestCase.java
@@ -73,7 +73,7 @@ public void closeIndex() throws IOException {
     }
 
     @Override
-    protected LuceneMinFactory simple() {
+    protected LuceneMinFactory simple(SimpleOptions options) {
         return simple(getNumberTypeTest(), randomFrom(DataPartitioning.values()), between(1, 10_000), 100);
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneSourceOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneSourceOperatorTests.java
@@ -72,7 +72,7 @@ public void closeIndex() throws IOException {
     }
 
     @Override
-    protected LuceneSourceOperator.Factory simple() {
+    protected LuceneSourceOperator.Factory simple(SimpleOptions options) {
         return simple(randomFrom(DataPartitioning.values()), between(1, 10_000), 100, scoring);
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneTopNSourceOperatorScoringTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneTopNSourceOperatorScoringTests.java
@@ -58,7 +58,7 @@ private void closeIndex() throws IOException {
     }
 
     @Override
-    protected LuceneTopNSourceOperator.Factory simple() {
+    protected LuceneTopNSourceOperator.Factory simple(SimpleOptions options) {
         return simple(DataPartitioning.SHARD, 10_000, 100);
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneTopNSourceOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/LuceneTopNSourceOperatorTests.java
@@ -63,7 +63,7 @@ private void closeIndex() throws IOException {
     }
 
     @Override
-    protected LuceneTopNSourceOperator.Factory simple() {
+    protected LuceneTopNSourceOperator.Factory simple(SimpleOptions options) {
         return simple(DataPartitioning.SHARD, 10_000, 100);
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/TimeSeriesSourceOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/TimeSeriesSourceOperatorTests.java
@@ -328,7 +328,7 @@ public void testMatchNone() throws Exception {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return createTimeSeriesSourceOperator(directory, r -> this.reader = r, randomBoolean(), List.of(), 1, 1, false, writer -> {
             long timestamp = DateFieldMapper.DEFAULT_DATE_TIME_FORMATTER.parseMillis("2024-01-01T00:00:00Z");
             writeTS(writer, timestamp, new Object[] { "hostname", "host-01" }, new Object[] { "voltage", 2 });
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/ValueSourceReaderTypeConversionTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/ValueSourceReaderTypeConversionTests.java
@@ -216,7 +216,7 @@ private IndexReader reader(String indexKey) {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return factory(initShardContexts(), mapperService("index1").fieldType("long"), ElementType.LONG);
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/ValuesSourceReaderOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/ValuesSourceReaderOperatorTests.java
@@ -127,7 +127,7 @@ public void closeIndex() throws IOException {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         if (reader == null) {
             // Init a reader if one hasn't been built, so things don't blow up
             try {
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ChangePointOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ChangePointOperatorTests.java
@@ -70,7 +70,7 @@ protected void assertSimpleOutput(List<Page> input, List<Page> results) {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return new ChangePointOperator.Factory(0, null, 0, 0);
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ColumnExtractOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ColumnExtractOperatorTests.java
@@ -48,7 +48,7 @@ public String toString() {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         Supplier<ColumnExtractOperator.Evaluator> expEval = () -> new FirstWord(0);
         return new ColumnExtractOperator.Factory(
             new ElementType[] { ElementType.BYTES_REF },
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ColumnLoadOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ColumnLoadOperatorTests.java
@@ -64,7 +64,7 @@ protected void assertSimpleOutput(List<Page> input, List<Page> results) {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return new ColumnLoadOperator.Factory(
             new ColumnLoadOperator.Values(
                 "values",
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/EvalOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/EvalOperatorTests.java
@@ -68,7 +68,7 @@ public void close() {}
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return new EvalOperator.EvalOperatorFactory(new EvalOperator.ExpressionEvaluator.Factory() {
             @Override
             public EvalOperator.ExpressionEvaluator get(DriverContext context) {
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/FilterOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/FilterOperatorTests.java
@@ -54,7 +54,7 @@ public void close() {}
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return new FilterOperator.FilterOperatorFactory(new EvalOperator.ExpressionEvaluator.Factory() {
 
             @Override
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ForkingOperatorTestCase.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ForkingOperatorTestCase.java
@@ -57,7 +57,7 @@ public abstract class ForkingOperatorTestCase extends OperatorTestCase {
     protected abstract Operator.OperatorFactory simpleWithMode(AggregatorMode mode);
 
     @Override
-    protected final Operator.OperatorFactory simple() {
+    protected final Operator.OperatorFactory simple(SimpleOptions options) {
         return simpleWithMode(AggregatorMode.SINGLE);
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/IteratorAppendPageTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/IteratorAppendPageTests.java
@@ -103,7 +103,7 @@ protected void assertSimpleOutput(List<Page> input, List<Page> results) {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return new IteratorAppendPage.Factory();
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/IteratorRemovePageTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/IteratorRemovePageTests.java
@@ -105,7 +105,7 @@ protected void assertSimpleOutput(List<Page> input, List<Page> results) {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return new IteratorRemovePage.Factory();
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/LimitOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/LimitOperatorTests.java
@@ -27,7 +27,7 @@
 
 public class LimitOperatorTests extends OperatorTestCase {
     @Override
-    protected LimitOperator.Factory simple() {
+    protected LimitOperator.Factory simple(SimpleOptions options) {
         return new LimitOperator.Factory(100);
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/MvExpandOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/MvExpandOperatorTests.java
@@ -49,7 +49,7 @@ protected Page createPage(int positionOffset, int length) {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return new MvExpandOperator.Factory(0, randomIntBetween(1, 1000));
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/OutputOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/OutputOperatorTests.java
@@ -17,7 +17,7 @@
 
 public class OutputOperatorTests extends AnyOperatorTestCase {
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return new OutputOperator.OutputOperatorFactory(List.of("a"), p -> p, p -> {});
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ProjectOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ProjectOperatorTests.java
@@ -66,7 +66,7 @@ protected SourceOperator simpleInput(BlockFactory blockFactory, int end) {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return new ProjectOperator.ProjectOperatorFactory(Arrays.asList(1));
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/RowInTableLookupOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/RowInTableLookupOperatorTests.java
@@ -79,7 +79,7 @@ private void assertSimpleOutput(List<Page> input, List<Page> results, int keyCha
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         return new RowInTableLookupOperator.Factory(
             new RowInTableLookupOperator.Key[] {
                 new RowInTableLookupOperator.Key(
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/SampleOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/SampleOperatorTests.java
@@ -40,7 +40,7 @@ protected void assertSimpleOutput(List<Page> input, List<Page> results) {
     }
 
     @Override
-    protected SampleOperator.Factory simple() {
+    protected SampleOperator.Factory simple(SimpleOptions options) {
         return new SampleOperator.Factory(0.5, randomInt());
     }
 
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/StringExtractOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/StringExtractOperatorTests.java
@@ -41,7 +41,7 @@ public Map<String, String> apply(String s) {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         Supplier<Function<String, Map<String, String>>> expEval = () -> new FirstWord("test");
         return new StringExtractOperator.StringExtractOperatorFactory(
             new String[] { "test" },
diff --git a/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/topn/TopNOperatorTests.java b/x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/topn/TopNOperatorTests.java
@@ -130,7 +130,7 @@ public class TopNOperatorTests extends OperatorTestCase {
     );
 
     @Override
-    protected TopNOperator.TopNOperatorFactory simple() {
+    protected TopNOperator.TopNOperatorFactory simple(SimpleOptions options) {
         return new TopNOperator.TopNOperatorFactory(
             4,
             List.of(LONG),
diff --git a/x-pack/plugin/esql/compute/test/src/main/java/org/elasticsearch/compute/test/AnyOperatorTestCase.java b/x-pack/plugin/esql/compute/test/src/main/java/org/elasticsearch/compute/test/AnyOperatorTestCase.java
@@ -32,11 +32,27 @@
  * Superclass for testing any {@link Operator}, including {@link SourceOperator}s.
  */
 public abstract class AnyOperatorTestCase extends ComputeTestCase {
+    /**
+     * @param requiresDeterministicFactory
+     *          True if the returned {@link Operator.OperatorFactory} should always return a deterministic operator.
+     *          That is, for two different calls, both operators should work in the same way.
+     */
+    protected record SimpleOptions(boolean requiresDeterministicFactory) {
+        public static final SimpleOptions DEFAULT = new SimpleOptions(false);
+    }
+
     /**
      * The operator configured a "simple" or basic way, used for smoke testing
      * descriptions, {@link CircuitBreaker}s, and scatter/gather.
      */
-    protected abstract Operator.OperatorFactory simple();
+    protected abstract Operator.OperatorFactory simple(SimpleOptions options);
+
+    /**
+     * Calls {@link #simple(SimpleOptions)} with the default options.
+     */
+    protected final Operator.OperatorFactory simple() {
+        return simple(SimpleOptions.DEFAULT);
+    }
 
     /**
      * The description of the operator produced by {@link #simple}.
diff --git a/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/enrich/LookupFromIndexOperatorTests.java b/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/enrich/LookupFromIndexOperatorTests.java
@@ -123,7 +123,7 @@ protected void assertSimpleOutput(List<Page> input, List<Page> results) {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         String sessionId = "test";
         CancellableTask parentTask = new CancellableTask(0, "test", "test", "test", TaskId.EMPTY_TASK_ID, Map.of());
         int maxOutstandingRequests = 1;
diff --git a/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/inference/RerankOperatorTests.java b/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/inference/RerankOperatorTests.java
@@ -88,7 +88,7 @@ public void shutdownThreadPool() {
     }
 
     @Override
-    protected Operator.OperatorFactory simple() {
+    protected Operator.OperatorFactory simple(SimpleOptions options) {
         InferenceRunner inferenceRunner = mockedSimpleInferenceRunner();
         return new RerankOperator.Factory(inferenceRunner, SIMPLE_INFERENCE_ID, SIMPLE_QUERY, rowEncoderFactory, scoreChannel);
     }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public void closeIndex() throws IOException {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`@Override`
`54`		`- protected LuceneCountOperator.Factory simple() {`
	`54`	`+ protected LuceneCountOperator.Factory simple(SimpleOptions options) {`
`55`	`55`	`return simple(randomFrom(DataPartitioning.values()), between(1, 10_000), 100);`
`56`	`56`	`}`
`57`	`57`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public void closeIndex() throws IOException {`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`@Override`
`76`		`- protected LuceneMaxFactory simple() {`
	`76`	`+ protected LuceneMaxFactory simple(SimpleOptions options) {`
`77`	`77`	`return simple(getNumberTypeTest(), randomFrom(DataPartitioning.values()), between(1, 10_000), 100);`
`78`	`78`	`}`
`79`	`79`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public void closeIndex() throws IOException {`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`@Override`
`75`		`- protected LuceneSourceOperator.Factory simple() {`
	`75`	`+ protected LuceneSourceOperator.Factory simple(SimpleOptions options) {`
`76`	`76`	`return simple(randomFrom(DataPartitioning.values()), between(1, 10_000), 100, scoring);`
`77`	`77`	`}`
`78`	`78`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ private void closeIndex() throws IOException {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`@Override`
`61`		`- protected LuceneTopNSourceOperator.Factory simple() {`
	`61`	`+ protected LuceneTopNSourceOperator.Factory simple(SimpleOptions options) {`
`62`	`62`	`return simple(DataPartitioning.SHARD, 10_000, 100);`
`63`	`63`	`}`
`64`	`64`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ private void closeIndex() throws IOException {`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`@Override`
`66`		`- protected LuceneTopNSourceOperator.Factory simple() {`
	`66`	`+ protected LuceneTopNSourceOperator.Factory simple(SimpleOptions options) {`
`67`	`67`	`return simple(DataPartitioning.SHARD, 10_000, 100);`
`68`	`68`	`}`
`69`	`69`
Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ public void testMatchNone() throws Exception {`
`328`	`328`	`}`
`329`	`329`
`330`	`330`	`@Override`
`331`		`- protected Operator.OperatorFactory simple() {`
	`331`	`+ protected Operator.OperatorFactory simple(SimpleOptions options) {`
`332`	`332`	`return createTimeSeriesSourceOperator(directory, r -> this.reader = r, randomBoolean(), List.of(), 1, 1, false, writer -> {`
`333`	`333`	`long timestamp = DateFieldMapper.DEFAULT_DATE_TIME_FORMATTER.parseMillis("2024-01-01T00:00:00Z");`
`334`	`334`	`writeTS(writer, timestamp, new Object[] { "hostname", "host-01" }, new Object[] { "voltage", 2 });`
Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ private IndexReader reader(String indexKey) {`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`@Override`
`219`		`- protected Operator.OperatorFactory simple() {`
	`219`	`+ protected Operator.OperatorFactory simple(SimpleOptions options) {`
`220`	`220`	`return factory(initShardContexts(), mapperService("index1").fieldType("long"), ElementType.LONG);`
`221`	`221`	`}`
`222`	`222`
Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ public void closeIndex() throws IOException {`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`@Override`
`130`		`- protected Operator.OperatorFactory simple() {`
	`130`	`+ protected Operator.OperatorFactory simple(SimpleOptions options) {`
`131`	`131`	`if (reader == null) {`
`132`	`132`	`// Init a reader if one hasn't been built, so things don't blow up`
`133`	`133`	`try {`