Merge remote-tracking branch 'origin/main' into lucene_snapshot

Author: elasticsearchmachine

rest-api-spec/src/main/resources/rest-api-spec/api/indices.segments.json

@@ -51,15 +51,6 @@
         ],
         "default":"open",
         "description":"Whether to expand wildcard expression to concrete indices that are open, closed or both."
-      },
-      "verbose":{
-        "type":"boolean",
-        "description":"Includes detailed memory usage by Lucene.",
-        "default":false,
-        "deprecated" : {
-          "version" : "8.0.0",
-          "description" : "lucene no longer keeps track of segment memory overhead as it is largely off-heap"
-        }
       }
     }
   }

server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestIndicesSegmentsAction.java

@@ -13,8 +13,6 @@
 import org.elasticsearch.action.support.IndicesOptions;
 import org.elasticsearch.client.internal.node.NodeClient;
 import org.elasticsearch.common.Strings;
-import org.elasticsearch.common.logging.DeprecationCategory;
-import org.elasticsearch.common.logging.DeprecationLogger;
 import org.elasticsearch.rest.BaseRestHandler;
 import org.elasticsearch.rest.RestRequest;
 import org.elasticsearch.rest.Scope;
@@ -30,8 +28,6 @@
 @ServerlessScope(Scope.INTERNAL)
 public class RestIndicesSegmentsAction extends BaseRestHandler {
 
-    private static final DeprecationLogger DEPRECATION_LOGGER = DeprecationLogger.getLogger(RestIndicesSegmentsAction.class);
-
     public RestIndicesSegmentsAction() {}
 
     @Override
@@ -49,13 +45,6 @@ public RestChannelConsumer prepareRequest(final RestRequest request, final NodeC
         IndicesSegmentsRequest indicesSegmentsRequest = new IndicesSegmentsRequest(
             Strings.splitStringByCommaToArray(request.param("index"))
         ).withVectorFormatsInfo(request.paramAsBoolean("vector_formats", false));
-        if (request.hasParam("verbose")) {
-            DEPRECATION_LOGGER.warn(
-                DeprecationCategory.INDICES,
-                "indices_segments_action_verbose",
-                "The [verbose] query parameter for [indices_segments_action] has no effect and is deprecated"
-            );
-        }
         indicesSegmentsRequest.indicesOptions(IndicesOptions.fromRequest(request, indicesSegmentsRequest.indicesOptions()));
         return channel -> new RestCancellableNodeClient(client, request.getHttpChannel()).admin()
             .indices()