Skip to content

Commit 4245e18

Browse files
Fix UTs and Unmute (#137190)
ESQL: Fix failing UTs and Unmute
1 parent cf35486 commit 4245e18

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

muted-tests.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -501,18 +501,6 @@ tests:
501501
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeMetricsIT
502502
method: test
503503
issue: https://github.com/elastic/elasticsearch/issues/137071
504-
- class: org.elasticsearch.xpack.esql.plugin.MatchFunctionIT
505-
method: testMatchWithLookupJoinOnMatch
506-
issue: https://github.com/elastic/elasticsearch/issues/137137
507-
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
508-
method: test {csv-spec:lookup-join-expression.LookupJoinExpressionWithTerm}
509-
issue: https://github.com/elastic/elasticsearch/issues/137157
510-
- class: org.elasticsearch.xpack.esql.qa.single_node.EsqlSpecIT
511-
method: test {csv-spec:lookup-join-expression.LookupJoinExpressionWithTerm}
512-
issue: https://github.com/elastic/elasticsearch/issues/137157
513-
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeForkIT
514-
method: test {csv-spec:lookup-join-expression.LookupJoinExpressionWithTerm}
515-
issue: https://github.com/elastic/elasticsearch/issues/137160
516504
- class: org.elasticsearch.cluster.routing.allocation.decider.WriteLoadConstraintDeciderIT
517505
method: testCanRemainNotPreferredIsIgnoredWhenAllOtherNodesReturnNotPreferred
518506
issue: https://github.com/elastic/elasticsearch/issues/137162

x-pack/plugin/esql/qa/testFixtures/src/main/resources/lookup-join-expression.csv-spec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -957,6 +957,7 @@ id_left:integer | name_left:keyword | other1_from_first_join:keyword | other1:ke
957957
lookupJoinExpressionWithTerm
958958
required_capability: join_lookup_v12
959959
required_capability: lookup_join_with_full_text_function
960+
required_capability: term_function
960961

961962
FROM multi_column_joinable
962963
| RENAME id_int AS id_left, is_active_bool AS is_active_left
@@ -1016,6 +1017,7 @@ id_left:integer | name_str:keyword | extra1:keyword | other1:keyword | other2:in
10161017
lookupJoinExpressionWithMultiMatch
10171018
required_capability: join_lookup_v12
10181019
required_capability: lookup_join_with_full_text_function
1020+
required_capability: multi_match_function
10191021

10201022
FROM multi_column_joinable
10211023
| RENAME id_int AS id_left, is_active_bool AS is_active_left, name_str AS name_str_left

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/plugin/MatchFunctionIT.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,7 @@ public void testMatchWithLookupJoinOnMatch() {
319319
| rename id as id_left
320320
| LOOKUP JOIN test_lookup ON id_left == id and MATCH(lookup_content, "fox")
321321
| WHERE id > 0
322+
| SORT id, id_left, content, lookup_content
322323
""";
323324
try (var resp = run(query)) {
324325
assertColumnNames(resp.columns(), List.of("content", "id_left", "id", "lookup_content"));

0 commit comments

Comments
 (0)