Revert useless node transform changes.

Author: afoucret

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/tree/Node.java

@@ -6,8 +6,6 @@
  */
 package org.elasticsearch.xpack.esql.core.tree;
 
-import org.elasticsearch.action.ActionListener;
-import org.elasticsearch.action.support.CountDownActionListener;
 import org.elasticsearch.common.io.stream.NamedWriteable;
 import org.elasticsearch.xpack.esql.core.QlIllegalArgumentException;
 
@@ -16,8 +14,6 @@
 import java.util.Iterator;
 import java.util.List;
 import java.util.Objects;
-import java.util.concurrent.atomic.AtomicReference;
-import java.util.function.BiConsumer;
 import java.util.function.Consumer;
 import java.util.function.Function;
 import java.util.function.Predicate;
@@ -191,45 +187,16 @@ public T transformDown(Function<? super T, ? extends T> rule) {
         return node.transformChildren(child -> child.transformDown(rule));
     }
 
-    @SuppressWarnings("unchecked")
-    public void transformDown(BiConsumer<T, ActionListener<T>> rule, ActionListener<T> listener) {
-        // First apply the rule to the current node (top-down)
-        rule.accept((T) this, listener.delegateFailureAndWrap((l, transformedNode) -> {
-            // Then recursively transform the children with the same rule
-            transformedNode.transformChildren((child, childListener) -> child.transformDown(rule, childListener), l);
-        }));
-    }
-
     @SuppressWarnings("unchecked")
     public <E extends T> T transformDown(Class<E> typeToken, Function<E, ? extends T> rule) {
         return transformDown((t) -> (typeToken.isInstance(t) ? rule.apply((E) t) : t));
     }
 
-    @SuppressWarnings("unchecked")
-    public <E extends T> void transformDown(Class<E> typeToken, BiConsumer<E, ActionListener<T>> rule, ActionListener<T> listener) {
-        transformDown(typeToken::isInstance, rule, listener);
-    }
-
     @SuppressWarnings("unchecked")
     public <E extends T> T transformDown(Predicate<Node<?>> nodePredicate, Function<E, ? extends T> rule) {
         return transformDown((t) -> (nodePredicate.test(t) ? rule.apply((E) t) : t));
     }
 
-    @SuppressWarnings("unchecked")
-    public <E extends T> void transformDown(
-        Predicate<Node<?>> nodePredicate,
-        BiConsumer<E, ActionListener<T>> rule,
-        ActionListener<T> listener
-    ) {
-        transformDown((T node, ActionListener<T> l) -> {
-            if (nodePredicate.test(node)) {
-                rule.accept((E) node, l);
-            } else {
-                l.onResponse(node);
-            }
-        }, listener);
-    }
-
     @SuppressWarnings("unchecked")
     public T transformUp(Function<? super T, ? extends T> rule) {
         T transformed = transformChildren(child -> child.transformUp(rule));
@@ -238,48 +205,15 @@ public T transformUp(Function<? super T, ? extends T> rule) {
     }
 
     @SuppressWarnings("unchecked")
-    public void transformUp(BiConsumer<T, ActionListener<T>> rule, ActionListener<T> listener) {
-        // First, recursively transform the children (depth-first, bottom-up) using the same async rule
-        transformChildren(
-            // traversal operation applied to each child
-            (child, childListener) -> child.transformUp(rule, childListener),
-            // After all children are transformed, apply the rule to the (possibly) new current node
-            listener.delegateFailureAndWrap((l, transformedChildrenNode) -> {
-                T node = transformedChildrenNode.equals(this) ? (T) this : transformedChildrenNode;
-                rule.accept(node, l);
-            })
-        );
-    }
-
     public <E extends T> T transformUp(Class<E> typeToken, Function<E, ? extends T> rule) {
-        return transformUp(typeToken::isInstance, rule);
-    }
-
-    public <E extends T> void transformUp(Class<E> typeToken, BiConsumer<E, ActionListener<T>> rule, ActionListener<T> listener) {
-        transformUp(typeToken::isInstance, rule, listener);
+        return transformUp((t) -> (typeToken.isInstance(t) ? rule.apply((E) t) : t));
     }
 
     @SuppressWarnings("unchecked")
     public <E extends T> T transformUp(Predicate<Node<?>> nodePredicate, Function<E, ? extends T> rule) {
         return transformUp((t) -> (nodePredicate.test(t) ? rule.apply((E) t) : t));
     }
 
-    @SuppressWarnings("unchecked")
-    public <E extends T> void transformUp(
-        Predicate<Node<?>> nodePredicate,
-        BiConsumer<E, ActionListener<T>> rule,
-        ActionListener<T> listener
-    ) {
-        transformUp((T node, ActionListener<T> l) -> {
-            if (nodePredicate.test(node)) {
-                E typedNode = (E) node;
-                rule.accept((E) node, l);
-            } else {
-                l.onResponse(node);
-            }
-        }, listener);
-    }
-
     @SuppressWarnings("unchecked")
     protected <R extends Function<? super T, ? extends T>> T transformChildren(Function<T, ? extends T> traversalOperation) {
         boolean childrenChanged = false;
@@ -304,35 +238,6 @@ public <E extends T> void transformUp(
         return (childrenChanged ? replaceChildrenSameSize(transformedChildren) : (T) this);
     }
 
-    @SuppressWarnings("unchecked")
-    protected void transformChildren(BiConsumer<? super T, ActionListener<T>> traversalOperation, ActionListener<T> listener) {
-        if (children.isEmpty()) {
-            listener.onResponse((T) this);
-            return;
-        }
-
-        final AtomicReference<List<T>> transformedChildren = new AtomicReference<>(null);
-
-        CountDownActionListener countDownListener = new CountDownActionListener(
-            children.size(),
-            listener.delegateFailureIgnoreResponseAndWrap((l) -> {
-                l.onResponse(transformedChildren.get() != null ? replaceChildren(transformedChildren.get()) : (T) this);
-            })
-        );
-
-        for (int i = 0, s = children.size(); i < s; i++) {
-            T child = children.get(i);
-            final int childId = i;
-            traversalOperation.accept(child, countDownListener.map(next -> {
-                if (child.equals(next) == false) {
-                    transformedChildren.compareAndSet(null, new ArrayList<>(children));
-                    transformedChildren.get().set(childId, next);
-                }
-                return null;
-            }));
-        }
-    }
-
     public final T replaceChildrenSameSize(List<T> newChildren) {
         if (newChildren.size() != children.size()) {
             throw new QlIllegalArgumentException(
@@ -352,38 +257,14 @@ public <E> T transformPropertiesOnly(Class<E> typeToken, Function<? super E, ? e
         return transformNodeProps(typeToken, rule);
     }
 
-    public <E> void transformPropertiesOnly(
-        Class<E> typeToken,
-        BiConsumer<? super E, ActionListener<? super E>> rule,
-        ActionListener<T> listener
-    ) {
-        transformNodeProps(typeToken, rule, listener);
-    }
-
     public <E> T transformPropertiesDown(Class<E> typeToken, Function<? super E, ? extends E> rule) {
         return transformDown(t -> t.transformNodeProps(typeToken, rule));
     }
 
-    public <E> void transformPropertiesDown(
-        Class<E> typeToken,
-        BiConsumer<? super E, ActionListener<? super E>> rule,
-        ActionListener<T> listener
-    ) {
-        transformDown((t, l) -> t.transformNodeProps(typeToken, rule, l), listener);
-    }
-
     public <E> T transformPropertiesUp(Class<E> typeToken, Function<? super E, ? extends E> rule) {
         return transformUp(t -> t.transformNodeProps(typeToken, rule));
     }
 
-    public <E> void transformPropertiesUp(
-        Class<E> typeToken,
-        BiConsumer<? super E, ActionListener<? super E>> rule,
-        ActionListener<T> listener
-    ) {
-        transformUp((t, l) -> t.transformNodeProps(typeToken, rule, l), listener);
-    }
-
     /**
      * Transform this node's properties.
      * <p>
@@ -396,14 +277,6 @@ protected final <E> T transformNodeProps(Class<E> typeToken, Function<? super E,
         return info().transform(rule, typeToken);
     }
 
-    protected final <E> void transformNodeProps(
-        Class<E> typeToken,
-        BiConsumer<? super E, ActionListener<? super E>> rule,
-        ActionListener<T> listener
-    ) {
-        info().transform(rule, typeToken, listener);
-    }
-
     /**
      * Return the information about this node.
      * <p>