Skip to content

Commit 442c032

Browse files
authored
ESQL: Fix DateDiff flaky test configuration (#138877)
Fixes #138772 The randomConfiguration() function generates a random query text unless it receives a explicit one. That random query makes the Source deserialization fail.
1 parent 5404594 commit 442c032

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

x-pack/plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql/ConfigurationTestUtils.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ public static Configuration randomConfiguration() {
5151
return randomConfiguration(randomRealisticUnicodeOfLength(len), randomTables());
5252
}
5353

54+
public static Configuration randomConfiguration(String query) {
55+
return randomConfiguration(query, randomTables());
56+
}
57+
5458
public static Configuration randomConfiguration(String query, Map<String, Map<String, Column>> tables) {
5559
var zoneId = randomZone();
5660
var locale = randomLocale(random());

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/date/DateDiffTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ private static List<TestCaseSupplier> makeSuppliers(
152152
Instant endTimestamp = Instant.parse(endTimestampString);
153153

154154
Supplier<Configuration> configurationSupplier = () -> timezone == null
155-
? randomConfiguration()
155+
? randomConfiguration(TEST_SOURCE.text())
156156
: configurationForTimezone(ZoneId.of(timezone));
157157

158158
return Stream.of(DataType.KEYWORD, DataType.TEXT)

0 commit comments

Comments
 (0)