Skip to content

Commit 44f35fc

Browse files
committed
Small test improvement.
1 parent db8cdb2 commit 44f35fc

File tree

1 file changed

+20
-22
lines changed

1 file changed

+20
-22
lines changed

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/inference/bulk/BulkInferenceRunnerTests.java

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,13 @@
2929
import java.util.Iterator;
3030
import java.util.List;
3131
import java.util.concurrent.CountDownLatch;
32+
import java.util.concurrent.TimeUnit;
3233
import java.util.concurrent.atomic.AtomicReference;
3334

34-
import static org.hamcrest.Matchers.allOf;
35-
import static org.hamcrest.Matchers.empty;
36-
import static org.hamcrest.Matchers.equalTo;
37-
import static org.hamcrest.Matchers.notNullValue;
35+
import static org.hamcrest.Matchers.*;
3836
import static org.mockito.ArgumentMatchers.any;
3937
import static org.mockito.ArgumentMatchers.eq;
40-
import static org.mockito.Mockito.doAnswer;
41-
import static org.mockito.Mockito.mock;
42-
import static org.mockito.Mockito.when;
38+
import static org.mockito.Mockito.*;
4339

4440
public class BulkInferenceRunnerTests extends ESTestCase {
4541
private ThreadPool threadPool;
@@ -150,26 +146,28 @@ public void testParallelBulkExecution() throws Exception {
150146
CountDownLatch latch = new CountDownLatch(batches);
151147

152148
for (int i = 0; i < batches; i++) {
153-
List<InferenceAction.Request> requests = randomInferenceRequestList(between(1, 1_000));
154-
List<InferenceAction.Response> responses = randomInferenceResponseList(requests.size());
155-
156-
Client client = mockClient(invocation -> {
157-
runWithRandomDelay(() -> {
158-
ActionListener<InferenceAction.Response> l = invocation.getArgument(2);
159-
l.onResponse(responses.get(requests.indexOf(invocation.getArgument(1, InferenceAction.Request.class))));
149+
runWithRandomDelay(() -> {
150+
List<InferenceAction.Request> requests = randomInferenceRequestList(between(1, 1_000));
151+
List<InferenceAction.Response> responses = randomInferenceResponseList(requests.size());
152+
153+
Client client = mockClient(invocation -> {
154+
runWithRandomDelay(() -> {
155+
ActionListener<InferenceAction.Response> l = invocation.getArgument(2);
156+
l.onResponse(responses.get(requests.indexOf(invocation.getArgument(1, InferenceAction.Request.class))));
157+
});
158+
return null;
160159
});
161-
return null;
162-
});
163160

164-
ActionListener<List<InferenceAction.Response>> listener = ActionListener.wrap(r -> {
165-
assertThat(r, equalTo(responses));
166-
latch.countDown();
167-
}, ESTestCase::fail);
161+
ActionListener<List<InferenceAction.Response>> listener = ActionListener.wrap(r -> {
162+
assertThat(r, equalTo(responses));
163+
latch.countDown();
164+
}, ESTestCase::fail);
168165

169-
inferenceRunnerFactory(client).create(randomBulkExecutionConfig()).executeBulk(requestIterator(requests), listener);
166+
inferenceRunnerFactory(client).create(randomBulkExecutionConfig()).executeBulk(requestIterator(requests), listener);
167+
});
170168
}
171169

172-
latch.await();
170+
latch.await(10, TimeUnit.SECONDS);
173171
}
174172

175173
private BulkInferenceRunner.Factory inferenceRunnerFactory(Client client) {

0 commit comments

Comments
 (0)