Skip to content

Commit 46249a0

Browse files
committed
clarify comment in BWCLucene70Codec
Added update for V9 annotation so we don't forget, not a blocker for lucene 10 upgrade
1 parent 2318da1 commit 46249a0

File tree

1 file changed

+4
-2
lines changed
  • x-pack/plugin/old-lucene-versions/src/main/java/org/elasticsearch/xpack/lucene/bwc/codecs/lucene70

1 file changed

+4
-2
lines changed

x-pack/plugin/old-lucene-versions/src/main/java/org/elasticsearch/xpack/lucene/bwc/codecs/lucene70/BWCLucene70Codec.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.apache.lucene.codecs.StoredFieldsFormat;
2323
import org.apache.lucene.codecs.perfield.PerFieldDocValuesFormat;
2424
import org.apache.lucene.codecs.perfield.PerFieldPostingsFormat;
25+
import org.elasticsearch.core.UpdateForV9;
2526
import org.elasticsearch.xpack.lucene.bwc.codecs.BWCCodec;
2627
import org.elasticsearch.xpack.lucene.bwc.codecs.lucene60.Lucene60MetadataOnlyPointsFormat;
2728

@@ -32,8 +33,9 @@ public class BWCLucene70Codec extends BWCCodec {
3233
private final LiveDocsFormat liveDocsFormat = new Lucene50LiveDocsFormat();
3334
private final CompoundFormat compoundFormat = new Lucene50CompoundFormat();
3435
private final StoredFieldsFormat storedFieldsFormat;
35-
// TODO lucene 10 upgrade: resolve below hack that gets us past missing Lucene70 codec for now
36-
private final DocValuesFormat defaultDVFormat = null;
36+
@UpdateForV9
37+
// this needs addressing to support 7.x indices in 9.x
38+
private final DocValuesFormat defaultDVFormat = null; // DocValuesFormat.forName("Lucene70");
3739
private final DocValuesFormat docValuesFormat = new PerFieldDocValuesFormat() {
3840
@Override
3941
public DocValuesFormat getDocValuesFormatForField(String field) {

0 commit comments

Comments
 (0)