Fix NullPointerException in LongComparator caused by null search_after values

Author: Kguswo

server/src/main/java/org/elasticsearch/search/searchafter/SearchAfterBuilder.java

@@ -252,10 +252,7 @@ public static SearchAfterBuilder fromXContent(XContentParser parser) throws IOEx
                 } else if (token == XContentParser.Token.VALUE_BOOLEAN) {
                     values.add(parser.booleanValue());
                 } else if (token == XContentParser.Token.VALUE_NULL) {
-                    throw new ParsingException(
-                        parser.getTokenLocation(),
-                        "Values cannot contain null."
-                    );
+                    throw new ParsingException(parser.getTokenLocation(), "Values cannot contain null.");
                 } else {
                     throw new ParsingException(
                         parser.getTokenLocation(),

server/src/test/java/org/elasticsearch/search/searchafter/SearchAfterBuilderTests.java

@@ -286,13 +286,11 @@ public void testBuildFieldDocWithCollapse() {
     public void testSetSortValuesRejectsNull() {
         SearchAfterBuilder builder = new SearchAfterBuilder();
 
-        IllegalArgumentException e1 = expectThrows(IllegalArgumentException.class, () -> {
-            builder.setSortValues(new Object[]{ null });
-        });
+        IllegalArgumentException e1 = expectThrows(IllegalArgumentException.class, () -> { builder.setSortValues(new Object[] { null }); });
         assertThat(e1.getMessage(), equalTo("Values cannot contain null at position 0."));
 
         IllegalArgumentException e2 = expectThrows(IllegalArgumentException.class, () -> {
-            builder.setSortValues(new Object[]{ 123L, null, "test" });
+            builder.setSortValues(new Object[] { 123L, null, "test" });
         });
         assertThat(e2.getMessage(), equalTo("Values cannot contain null at position 1."));
     }
@@ -306,9 +304,7 @@ public void testFromXContentRejectsNull() throws Exception {
             parser.nextToken();
             parser.nextToken();
             parser.nextToken();
-            ParsingException e = expectThrows(ParsingException.class, () -> {
-                SearchAfterBuilder.fromXContent(parser);
-            });
+            ParsingException e = expectThrows(ParsingException.class, () -> { SearchAfterBuilder.fromXContent(parser); });
             assertThat(e.getMessage(), equalTo("Values cannot contain null."));
         }
     }
@@ -323,7 +319,7 @@ public void testBuildFieldDocRejectsNull() {
         SortAndFormats sortAndFormats = new SortAndFormats(sort, formats);
 
         IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> {
-            SearchAfterBuilder.buildFieldDoc(sortAndFormats, new Object[]{ null }, null);
+            SearchAfterBuilder.buildFieldDoc(sortAndFormats, new Object[] { null }, null);
         });
         assertThat(e.getMessage(), equalTo("Values cannot contain null at position 0."));
     }