remove logging

Author: limotova

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/Driver.java

@@ -7,8 +7,6 @@
 
 package org.elasticsearch.compute.operator;
 
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
 import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.action.support.ContextPreservingActionListener;
 import org.elasticsearch.action.support.SubscribableListener;
@@ -17,7 +15,6 @@
 import org.elasticsearch.compute.Describable;
 import org.elasticsearch.compute.data.Page;
 import org.elasticsearch.compute.operator.exchange.ExchangeSinkOperator;
-import org.elasticsearch.compute.operator.topn.TopNOperator;
 import org.elasticsearch.core.Nullable;
 import org.elasticsearch.core.Releasable;
 import org.elasticsearch.core.Releasables;
@@ -251,8 +248,6 @@ public void abort(Exception reason, ActionListener<Void> listener) {
         }
     }
 
-    private static final Logger logger = LogManager.getLogger(Driver.class);
-
     private IsBlockedResult runSingleLoopIteration() {
         driverContext.checkForEarlyTermination();
         boolean movedPage = false;
@@ -288,7 +283,6 @@ private IsBlockedResult runSingleLoopIteration() {
                         page.releaseBlocks();
                         throw e;
                     }
-                    logger.warn("INPUTTING PAGE TO OPERATOR " + nextOp);
                     nextOp.addInput(page);
                     movedPage = true;
                 }
@@ -333,15 +327,13 @@ private int closeEarlyFinishedOperators(ListIterator<Operator> operators) {
                 while (finishedOperators.hasNext()) {
                     Operator op = finishedOperators.next();
                     statusOfCompletedOperators.add(new OperatorStatus(op.toString(), op.status()));
-                    logger.warn("CLOSING OPERATOR " + op);
                     op.close();
                     finishedOperators.remove();
                 }
 
                 // Finish the next operator, which is now the first operator.
                 if (activeOperators.isEmpty() == false) {
                     Operator newRootOperator = activeOperators.get(0);
-                    logger.warn("FINISHING OPERATOR " + newRootOperator);
                     newRootOperator.finish();
                 }
                 return index;

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/topn/TopNOperator.java

@@ -7,8 +7,6 @@
 
 package org.elasticsearch.compute.operator.topn;
 
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
 import org.apache.lucene.util.Accountable;
 import org.apache.lucene.util.BytesRef;
 import org.apache.lucene.util.PriorityQueue;
@@ -49,8 +47,6 @@ public class TopNOperator implements Operator, Accountable {
     private static final byte SMALL_NULL = 0x01; // "null" representation for "nulls first"
     private static final byte BIG_NULL = 0x02; // "null" representation for "nulls last"
 
-    private static final Logger logger = LogManager.getLogger("TopNOperator");
-
     /**
      * Internal row to be used in the PriorityQueue instead of the full blown Page.
      * It mirrors somehow the Block build in the sense that it keeps around an array of offsets and a count of values (to account for
@@ -126,20 +122,15 @@ public void clearRefCounters() {
         }
     }
 
-
     static final class BytesOrder implements Releasable, Accountable {
         private static final long BASE_RAM_USAGE = RamUsageEstimator.shallowSizeOfInstance(BytesOrder.class);
         private final CircuitBreaker breaker;
         final List<SortOrder> sortOrders;
         final int[] endOffsets;
-        private static final Logger logger = LogManager.getLogger(BytesOrder.class);
-        private boolean open = true;
 
         BytesOrder(List<SortOrder> sortOrders, CircuitBreaker breaker, String label) {
             this.breaker = breaker;
             this.sortOrders = sortOrders;
-            logger.warn("ADDED " + memoryUsed(sortOrders.size()));
-            logger.warn("", new Throwable());
             breaker.addEstimateBytesAndMaybeBreak(memoryUsed(sortOrders.size()), label);
             this.endOffsets = new int[sortOrders.size()];
         }
@@ -169,10 +160,6 @@ public long ramBytesUsed() {
 
         @Override
         public void close() {
-//            assert open;
-            open = false;
-            logger.warn("REMOVING " + (-ramBytesUsed()));
-            logger.warn("", new Throwable());
             breaker.addWithoutBreaking(-ramBytesUsed());
         }
     }
@@ -193,10 +180,6 @@ static final class RowFiller {
                     page.getBlock(b)
                 );
             }
-            logger.warn("VALUE EXTRACTORS ARRAY LOOKS LIKE");
-            for (var v : valueExtractors) {
-                logger.warn("" + v);
-            }
             keyFactories = new KeyFactory[sortOrders.size()];
             for (int k = 0; k < keyFactories.length; k++) {
                 SortOrder so = sortOrders.get(k);
@@ -236,7 +219,6 @@ private void writeValues(int position, Row destination) {
                 if (refCounted != null) {
                     destination.setShardRefCountersAndShard(refCounted);
                 }
-                logger.warn("ENCODING VALUE FOR " + e +  " AT OFFSET " + destination.values.length());
                 e.writeValue(destination.values, position);
             }
         }
@@ -485,11 +467,6 @@ private Iterator<Page> toPages() {
                         );
                     }
                     p = 0;
-
-                    logger.warn("BUILDERS ARRAY LOOKS LIKE ");
-                    for (var b : builders) {
-                        logger.warn("" + b);
-                    }
                 }
 
                 try (Row row = list.get(i)) {
@@ -502,7 +479,6 @@ private Iterator<Page> toPages() {
                         }
                         keys.offset++;
                         keys.length--;
-                        logger.warn("DECODING KEY AT OFFSET " + keys.offset);
                         builders[so.channel].decodeKey(keys);
                     }
                     if (keys.length != 0) {
@@ -512,7 +488,6 @@ private Iterator<Page> toPages() {
                     BytesRef values = row.values.bytesRefView();
                     for (ResultBuilder builder : builders) {
                         builder.setNextRefCounted(row.shardRefCounter);
-                        logger.warn("DECODING VALUE FOR BUILDER " + builder + " AT OFFSET " + values.offset);
                         builder.decodeValue(values);
                     }
                     if (values.length != 0) {
@@ -542,9 +517,6 @@ private Iterator<Page> toPages() {
             assert builders == null;
             success = true;
             return result.iterator();
-        } catch (Throwable e) {
-            logger.warn("THREW AN EXCEPTION: ", e);
-            throw e;
         } finally {
             if (success == false) {
                 List<Releasable> close = new ArrayList<>(list);

x-pack/plugin/esql/qa/server/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/multi_node/GenerativeIT.java

@@ -7,7 +7,6 @@
 
 package org.elasticsearch.xpack.esql.qa.multi_node;
 
-import com.carrotsearch.randomizedtesting.annotations.Seed;
 import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
 
 import org.elasticsearch.common.settings.Settings;