Huge simplification of the bul inference runner & operator

Author: afoucret

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/inference/InferenceFunctionEvaluator.java

@@ -10,12 +10,13 @@
 import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.xpack.esql.core.expression.Expression;
 import org.elasticsearch.xpack.esql.core.expression.FoldContext;
+import org.elasticsearch.xpack.esql.inference.bulk.BulkInferenceRunner;
 
 public interface InferenceFunctionEvaluator {
 
     void eval(FoldContext foldContext, ActionListener<Expression> listener);
 
     interface Factory {
-        InferenceFunctionEvaluator get(InferenceRunner inferenceRunner);
+        InferenceFunctionEvaluator get(BulkInferenceRunner inferenceRunner);
     }
 }

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/inference/textembedding/TextEmbeddingFunctionEvaluator.java

@@ -21,20 +21,20 @@
 import org.elasticsearch.xpack.esql.core.type.DataType;
 import org.elasticsearch.xpack.esql.expression.function.inference.TextEmbedding;
 import org.elasticsearch.xpack.esql.inference.InferenceFunctionEvaluator;
-import org.elasticsearch.xpack.esql.inference.InferenceRunner;
+import org.elasticsearch.xpack.esql.inference.bulk.BulkInferenceRunner;
 
 import java.util.ArrayList;
 import java.util.List;
 
 public class TextEmbeddingFunctionEvaluator implements InferenceFunctionEvaluator {
 
-    private final InferenceRunner inferenceRunner;
+    private final BulkInferenceRunner bulkInferenceRunner;
 
     private final TextEmbedding f;
 
-    public TextEmbeddingFunctionEvaluator(TextEmbedding f, InferenceRunner inferenceRunner) {
+    public TextEmbeddingFunctionEvaluator(TextEmbedding f, BulkInferenceRunner bulkInferenceRunner) {
         this.f = f;
-        this.inferenceRunner = inferenceRunner;
+        this.bulkInferenceRunner = bulkInferenceRunner;
     }
 
     @Override
@@ -45,7 +45,7 @@ public void eval(FoldContext foldContext, ActionListener<Expression> listener) {
         String inferenceId = BytesRefs.toString(f.inferenceId().fold(foldContext));
         String inputText = BytesRefs.toString(f.inputText().fold(foldContext));
 
-        inferenceRunner.execute(inferenceRequest(inferenceId, inputText), listener.map(this::parseInferenceResponse));
+        //bulkInferenceRunner.executeBulk(inferenceRequest(inferenceId, inputText), listener.map(this::parseInferenceResponse));
     }
 
     private InferenceAction.Request inferenceRequest(String inferenceId, String inputText) {

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/LogicalPlanPreOptimizer.java

@@ -28,7 +28,7 @@ public class LogicalPlanPreOptimizer {
     private final List<PreOptimizerRule> rules;
 
     public LogicalPlanPreOptimizer(TransportActionServices services, LogicalPreOptimizerContext preOptimizerContext) {
-        rules = List.of(new InferenceFunctionConstantFolding(services.inferenceRunner(), preOptimizerContext.foldCtx()));
+        rules = List.of(new InferenceFunctionConstantFolding(services.bulkInferenceRunner(), preOptimizerContext.foldCtx()));
     }
 
     /**

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/rules/logical/preoptimizer/InferenceFunctionConstantFolding.java

@@ -12,7 +12,7 @@
 import org.elasticsearch.xpack.esql.core.expression.Expression;
 import org.elasticsearch.xpack.esql.core.expression.FoldContext;
 import org.elasticsearch.xpack.esql.expression.function.inference.InferenceFunction;
-import org.elasticsearch.xpack.esql.inference.InferenceRunner;
+import org.elasticsearch.xpack.esql.inference.bulk.BulkInferenceRunner;
 import org.elasticsearch.xpack.esql.plan.logical.LogicalPlan;
 
 import java.util.ArrayList;
@@ -31,17 +31,17 @@
  * appear after the first round of folding.
  */
 public class InferenceFunctionConstantFolding implements PreOptimizerRule {
-    private final InferenceRunner inferenceRunner;
+    private final BulkInferenceRunner bulkInferenceRunner;
     private final FoldContext foldContext;
 
     /**
      * Creates a new instance of the InferenceFunctionConstantFolding rule.
      *
-     * @param inferenceRunner the inference runner to use for evaluating inference functions
-     * @param foldContext     the fold context to use for evaluating inference functions
+     * @param bulkInferenceRunner the inference runner to use for evaluating inference functions
+     * @param foldContext         the fold context to use for evaluating inference functions
      */
-    public InferenceFunctionConstantFolding(InferenceRunner inferenceRunner, FoldContext foldContext) {
-        this.inferenceRunner = inferenceRunner;
+    public InferenceFunctionConstantFolding(BulkInferenceRunner bulkInferenceRunner, FoldContext foldContext) {
+        this.bulkInferenceRunner = bulkInferenceRunner;
         this.foldContext = foldContext;
     }
 
@@ -139,6 +139,6 @@ private List<InferenceFunction<?>> collectFoldableInferenceFunctions(LogicalPlan
      * @param listener          the listener to notify when the evaluation is complete
      */
     private void foldInferenceFunction(InferenceFunction<?> inferenceFunction, ActionListener<Expression> listener) {
-        inferenceFunction.inferenceEvaluatorFactory().get(inferenceRunner).eval(foldContext, listener);
+        inferenceFunction.inferenceEvaluatorFactory().get(bulkInferenceRunner).eval(foldContext, listener);
     }
 }