Skip to content

Commit 47dc480

Browse files
add more asserts
1 parent 75a63a0 commit 47dc480

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

server/src/test/java/org/elasticsearch/search/TelemetryMetrics/ShardSearchPhaseAPMMetricsTests.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,8 @@ public void testCanMatchSearch() {
265265
"1"
266266
);
267267

268-
final List<Measurement> fetchMeasurements = getTestTelemetryPlugin().getLongHistogramMeasurement(CAN_MATCH_SEARCH_PHASE_METRIC);
269-
assertEquals(num_primaries, fetchMeasurements.size());
268+
final List<Measurement> canMatchMeasurements = getTestTelemetryPlugin().getLongHistogramMeasurement(CAN_MATCH_SEARCH_PHASE_METRIC);
269+
assertEquals(num_primaries, canMatchMeasurements.size());
270270
}
271271

272272
private static void assertAttributes(List<Measurement> measurements, boolean isSystem, boolean isScroll) {
@@ -360,6 +360,8 @@ public void testTimeRangeFilterAllResults() {
360360
assertSearchHits(searchResponse, "1", "2");
361361
assertThat(searchResponse.getSkippedShards(), Matchers.greaterThanOrEqualTo(num_primaries - 2));
362362
});
363+
final List<Measurement> canMatchMeasurements = getTestTelemetryPlugin().getLongHistogramMeasurement(CAN_MATCH_SEARCH_PHASE_METRIC);
364+
assertEquals(num_primaries, canMatchMeasurements.size());
363365
final List<Measurement> queryMeasurements = getTestTelemetryPlugin().getLongHistogramMeasurement(QUERY_SEARCH_PHASE_METRIC);
364366
// the two docs are at most spread across two shards, other shards are empty and get filtered out
365367
assertThat(queryMeasurements.size(), Matchers.lessThanOrEqualTo(2));

0 commit comments

Comments
 (0)