Rename Text#length to Text#stringLength

Author: jordan-powers

libs/x-content/src/main/java/org/elasticsearch/xcontent/Text.java

@@ -34,15 +34,23 @@ public static Text[] convertFromStringArray(String[] strings) {
     private ByteBuffer bytes;
     private String text;
     private int hash;
-    private int length = -1;
+    private int stringLength = -1;
 
+    /**
+     * Construct a Text from a UTF-8 encoded ByteBuffer. Since no string length is specified, {@link #stringLength()}
+     * will perform a string conversion to measure the string length.
+     */
     public Text(ByteBuffer bytes) {
         this.bytes = bytes;
     }
 
-    public Text(ByteBuffer bytes, int length) {
+    /**
+     * Construct a Text from a UTF-8 encoded ByteBuffer and an explicit string length. Used to avoid string conversion
+     * in {@link #stringLength()}.
+     */
+    public Text(ByteBuffer bytes, int stringLength) {
         this.bytes = bytes;
-        this.length = length;
+        this.stringLength = stringLength;
     }
 
     public Text(String text) {
@@ -81,10 +89,10 @@ public String string() {
 
     @Override
     public int stringLength() {
-        if (length < 0) {
-            length = string().length();
+        if (stringLength < 0) {
+            stringLength = string().length();
         }
-        return length;
+        return stringLength;
     }
 
     @Override