Merge branch '8.19' into charlotte-connectorsRN-8.19.5

Author: charlotte-hoblik

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/InternalTestClustersPlugin.java

@@ -11,9 +11,7 @@
 
 import org.elasticsearch.gradle.VersionProperties;
 import org.elasticsearch.gradle.internal.info.GlobalBuildInfoPlugin;
-import org.elasticsearch.gradle.testclusters.ElasticsearchCluster;
 import org.elasticsearch.gradle.testclusters.TestClustersPlugin;
-import org.gradle.api.NamedDomainObjectContainer;
 import org.gradle.api.Plugin;
 import org.gradle.api.Project;
 
@@ -33,17 +31,5 @@ public void apply(Project project) {
             version -> (version.equals(VersionProperties.getElasticsearchVersion()) && buildParams.getSnapshotBuild() == false)
                 || buildParams.getBwcVersions().unreleasedInfo(version) == null
         );
-
-        NamedDomainObjectContainer<ElasticsearchCluster> testClusters = (NamedDomainObjectContainer<ElasticsearchCluster>) project
-            .getExtensions()
-            .getByName(TestClustersPlugin.EXTENSION_NAME);
-        // Limit the number of allocated processors for all nodes to 2 in the cluster by default.
-        // This is to ensure that the tests run consistently across different environments.
-        String processorCount = shouldConfigureTestClustersWithOneProcessor() ? "1" : "2";
-        testClusters.configureEach(elasticsearchCluster -> elasticsearchCluster.setting("node.processors", processorCount));
-    }
-
-    private boolean shouldConfigureTestClustersWithOneProcessor() {
-        return Boolean.parseBoolean(System.getProperty("tests.configure_test_clusters_with_one_processor", "false"));
     }
 }

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/TransportVersionDefinition.java

@@ -22,9 +22,11 @@ public static TransportVersionDefinition fromString(Path file, String contents,
 
         String idsLine = null;
         if (contents.isEmpty() == false) {
-            String[] lines = contents.split(System.lineSeparator());
+            // Regardless of whether windows newlines exist (they could be added by git), we split on line feed.
+            // All we care about skipping lines with the comment character, so the remaining \r won't matter
+            String[] lines = contents.split("\n");
             for (String line : lines) {
-                line = line.replaceAll("\\s+", "");
+                line = line.strip();
                 if (line.startsWith("#") == false) {
                     idsLine = line;
                     break;

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/TransportVersionUpperBound.java

@@ -24,9 +24,11 @@ public static TransportVersionUpperBound fromString(Path file, String contents)
         String branch = filename.substring(slashIndex == -1 ? 0 : (slashIndex + 1), filename.length() - 4);
 
         String idsLine = null;
-        String[] lines = contents.split(System.lineSeparator());
+        // Regardless of whether windows newlines exist (they could be added by git), we split on line feed.
+        // All we care about skipping lines with the comment character, so the remaining \r won't matter
+        String[] lines = contents.split("\n");
         for (String line : lines) {
-            line = line.replaceAll("\\s+", "");
+            line = line.strip();
             if (line.startsWith("#") == false) {
                 idsLine = line;
                 break;

build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java

@@ -1406,6 +1406,15 @@ private void createConfiguration() {
             baseConfig.put("cluster.service.slow_master_task_logging_threshold", "5s");
         }
 
+        // Limit the number of allocated processors for all nodes in the cluster by default.
+        // This is to ensure that the tests run consistently across different environments.
+        String processorCount = shouldConfigureTestClustersWithOneProcessor() ? "1" : "2";
+        if (getVersion().onOrAfter("7.6.0")) {
+            baseConfig.put("node.processors", processorCount);
+        } else {
+            baseConfig.put("processors", processorCount);
+        }
+
         baseConfig.put("action.destructive_requires_name", "false");
 
         HashSet<String> overriden = new HashSet<>(baseConfig.keySet());
@@ -1791,4 +1800,8 @@ private static class LinkCreationException extends UncheckedIOException {
             super(message, cause);
         }
     }
+
+    private boolean shouldConfigureTestClustersWithOneProcessor() {
+        return Boolean.parseBoolean(System.getProperty("tests.configure_test_clusters_with_one_processor", "false"));
+    }
 }

docs/reference/release-notes.asciidoc

@@ -6,6 +6,7 @@
 
 This section summarizes the changes in each release.
 
+* <<release-notes-8.19.5>>
 * <<release-notes-8.19.4>>
 * <<release-notes-8.19.3>>
 * <<release-notes-8.19.2>>
@@ -106,6 +107,7 @@ This section summarizes the changes in each release.
 
 --
 
+include::release-notes/8.19.5.asciidoc[]
 include::release-notes/8.19.4.asciidoc[]
 include::release-notes/8.19.3.asciidoc[]
 include::release-notes/8.19.2.asciidoc[]

docs/reference/release-notes/8.19.5.asciidoc

@@ -0,0 +1,73 @@
+[[release-notes-8.19.5]]
+== {es} version 8.19.5
+
+coming[8.19.5]
+
+Also see <<breaking-changes-8.19,Breaking changes in 8.19>>.
+
+[IMPORTANT]
+====
+The 8.19.5 release contains fixes for potential security vulnerabilities.
+Please see our https://discuss.elastic.co/c/announcements/security-announcements/31[security advisory] for more details.
+====
+
+[[bug-8.19.5]]
+[float]
+=== Bug fixes
+
+Aggregations::
+* Propagates filter() to aggregation functions' surrogates {es-pull}134461[#134461] (issue: {es-issue}134380[#134380])
+
+Codec::
+* Address es819 tsdb doc values format performance bug {es-pull}135505[#135505] (issue: {es-issue}135340[#135340])
+
+ES|QL::
+* Ban Limit + `MvExpand` before remote Enrich {es-pull}135051[#135051]
+* Fix async get results with inconsistent headers {es-pull}135078[#135078] (issue: {es-issue}135042[#135042])
+* Fix expiration time in ES|QL async {es-pull}135209[#135209] (issue: {es-issue}135169[#135169])
+
+Engine::
+* Bypass MMap arena grouping as this has caused issues with too many regions being mapped {es-pull}135012[#135012]
+* Fix deadlock in `ThreadPoolMergeScheduler` when a failing merge closes the `IndexWriter` {es-pull}134656[#134656]
+
+Geo::
+* `CentroidCalculator` does not return negative summation weights {es-pull}135176[#135176] (issue: {es-issue}131861[#131861])
+
+Infra/Core::
+* Bug fix: Facilitate second retrieval of the same value {es-pull}134790[#134790] (issue: {es-issue}134770[#134770])
+
+Infra/Node Lifecycle::
+* Fix systemd notify to use a shared arena {es-pull}135235[#135235]
+
+Ingest Node::
+* Correctly apply field path to JSON processor when adding contents to document root {es-pull}135479[#135479]
+
+Machine Learning::
+* Add .reindexed-v7-ml-anomalies-* to anomaly results template index pattern {es-pull}135270[#135270]
+* Gracefully shutdown model deployment when node is removed from assignment routing {es-pull}134673[#134673]
+* Reset health status on successful empty checkpoint {es-pull}135653[#135653] (issue: {es-issue}135650[#135650])
+* Tolerate mixed types in datafeed stats sort {es-pull}135096[#135096]
+
+Mapping::
+* Avoid holding references to `SearchExecutionContext` in `SourceConfirmedTextQuery` {es-pull}134887[#134887]
+* Fix for creating semantic_text fields on pre-8.11 indices crashing Elasticsearch {es-pull}135845[#135845]
+* Fixed match only text block loader not working when a keyword multi field is present {es-pull}134582[#134582]
+
+Search::
+* Fix KQL case-sensitivity for keyword fields in ES|QL {es-pull}135776[#135776] (issue: {es-issue}135772[#135772])
+
+Transform::
+* Fix a bug in the GET _transform API that incorrectly claims some Transform configurations are missing {es-pull}134963[#134963] (issue: {es-issue}134263[#134263])
+* Prevent Transform from queuing too many PIT close requests by waiting for PIT to close before finishing the checkpoint {es-pull}134955[#134955] (issue: {es-issue}134925[#134925])
+
+[[enhancement-8.19.5]]
+[float]
+=== Enhancements
+
+Audit::
+* Change reindex to use ::es-redacted:: filtering {es-pull}135414[#135414]
+
+Authorization::
+* [Island Browser] Add `manage`, `create_index`, `read`, `index`, `write`, `delete`, permission for third party agent indices `kibana_system` {es-pull}134636[#134636] (issue: {es-issue}134136[#134136])
+
+

test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/DefaultSettingsProvider.java

@@ -44,7 +44,11 @@ public Map<String, String> get(LocalNodeSpec nodeSpec) {
 
         // Limit the number of allocated processors for all nodes in the cluster by default.
         // This is to ensure that the tests run consistently across different environments.
-        settings.put("node.processors", "2");
+        if (nodeSpec.getVersion().onOrAfter("7.6.0")) {
+            settings.put("node.processors", "2");
+        } else {
+            settings.put("processors", "2");
+        }
 
         // Default the watermarks to absurdly low to prevent the tests from failing on nodes without enough disk space
         settings.put("cluster.routing.allocation.disk.watermark.low", "1b");