Removing the data stream settings feature flag

Author: masseyke

modules/data-streams/src/main/java/org/elasticsearch/datastreams/DataStreamsPlugin.java

@@ -283,10 +283,8 @@ public List<RestHandler> getRestHandlers(
         handlers.add(new RestGetDataStreamOptionsAction());
         handlers.add(new RestPutDataStreamOptionsAction());
         handlers.add(new RestDeleteDataStreamOptionsAction());
-        if (DataStream.LOGS_STREAM_FEATURE_FLAG) {
             handlers.add(new RestGetDataStreamSettingsAction());
             handlers.add(new RestUpdateDataStreamSettingsAction());
-        }
         return handlers;
     }
 

rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_data_stream_settings.json

@@ -5,8 +5,7 @@
       "description":"Gets a data stream's settings"
     },
     "stability":"stable",
-    "visibility": "feature_flag",
-    "feature_flag": "logs_stream",
+    "visibility": "public",
     "headers":{
       "accept": [ "application/json"]
     },

rest-api-spec/src/main/resources/rest-api-spec/api/indices.put_data_stream_settings.json

@@ -5,8 +5,7 @@
       "description":"Updates a data stream's settings"
     },
     "stability":"stable",
-    "visibility": "feature_flag",
-    "feature_flag": "logs_stream",
+    "visibility": "public",
     "headers":{
       "accept": [ "application/json"]
     },

server/src/main/java/org/elasticsearch/action/datastreams/GetDataStreamAction.java

@@ -418,11 +418,9 @@ public XContentBuilder toXContent(
                     builder.endArray();
                     builder.endObject();
                 }
-                if (DataStream.LOGS_STREAM_FEATURE_FLAG) {
                     builder.startObject(SETTINGS_FIELD.getPreferredName());
                     dataStream.getSettings().toXContent(builder, params);
                     builder.endObject();
-                }
 
                 builder.startObject(DataStream.FAILURE_STORE_FIELD.getPreferredName());
                 builder.field(FAILURE_STORE_ENABLED.getPreferredName(), failureStoreEffectivelyEnabled);

server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java

@@ -80,7 +80,6 @@ public final class DataStream implements SimpleDiffable<DataStream>, ToXContentO
     private static final Logger LOGGER = LogManager.getLogger(DataStream.class);
 
     public static final NodeFeature DATA_STREAM_FAILURE_STORE_FEATURE = new NodeFeature("data_stream.failure_store");
-    public static final boolean LOGS_STREAM_FEATURE_FLAG = new FeatureFlag("logs_stream").isEnabled();
     public static final TransportVersion ADDED_FAILURE_STORE_TRANSPORT_VERSION = TransportVersions.V_8_12_0;
     public static final TransportVersion ADDED_AUTO_SHARDING_EVENT_VERSION = TransportVersions.V_8_14_0;
     public static final TransportVersion ADD_DATA_STREAM_OPTIONS_VERSION = TransportVersions.V_8_16_0;