Skip to content

Commit 4a5804c

Browse files
committed
Add check on the flag for tests
1 parent 22adee0 commit 4a5804c

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

docs/changelog/125921.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ type: feature
55
highlight:
66
title: Allow direct IO for BBQ rescoring
77
body: |-
8-
BBQ rescoring can be drastically affected by the amount of available RAM
9-
for use in the page cache. When there is not enough RAM to fit the whole
8+
BBQ rescoring performance can be drastically affected by the amount of available RAM
9+
for use for the system page cache. When there is not enough RAM to fit all the
1010
vector data in memory, BBQ search latencies can be affected by as much as 5000x.
1111
Specifying the `vector.rescoring.directio=true` Java option on all vector search
12-
nodes changes rescoring to use direct IO, which eliminates these very high latencies
13-
from searches in low-memory scenarios, at a cost of a reduction
12+
nodes modifies rescoring to use direct IO, which eliminates these very high latencies
13+
from searches in low-memory scenarios, at a cost of a general reduction
1414
in vector search performance for BBQ indices.
1515
1616
This option is released in 9.1 as a tech preview whilst we analyse its effect

server/src/test/java/org/elasticsearch/index/codec/vectors/es818/ES818BinaryQuantizedVectorsFormatTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,8 @@ private Directory newFSDirectory() throws IOException {
333333
}
334334

335335
static void checkDirectIOSupported() {
336+
assumeTrue("Direct IO is not enabled", ES818BinaryQuantizedVectorsFormat.USE_DIRECT_IO);
337+
336338
Path path = createTempDir("directIOProbe");
337339
try (Directory dir = open(path); IndexOutput out = dir.createOutput("out", IOContext.DEFAULT)) {
338340
out.writeString("test");

server/src/test/java/org/elasticsearch/index/codec/vectors/es818/ES818HnswBinaryQuantizedVectorsFormatTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,8 @@ private Directory newFSDirectory() throws IOException {
221221
}
222222

223223
static void checkDirectIOSupported() {
224+
assumeTrue("Direct IO is not enabled", ES818BinaryQuantizedVectorsFormat.USE_DIRECT_IO);
225+
224226
Path path = createTempDir("directIOProbe");
225227
try (Directory dir = open(path); IndexOutput out = dir.createOutput("out", IOContext.DEFAULT)) {
226228
out.writeString("test");

0 commit comments

Comments
 (0)