Suppress aborting writes in repo analyzer tests

Author: DaveCTurner

x-pack/plugin/snapshot-repo-test-kit/qa/s3/src/javaRestTest/java/org/elasticsearch/repositories/blobstore/testkit/analyze/S3RepositoryAnalysisRestIT.java

@@ -54,6 +54,13 @@ protected String repositoryType() {
         return "s3";
     }
 
+    @Override
+    protected boolean abortWritesPermitted() {
+        // S3 SDK reads the full blob twice, once to compute the checksum and then again to do the upload; aborting a write operation blocks
+        // the checksum computation rather than the actual upload.
+        return false;
+    }
+
     @Override
     protected Settings repositorySettings() {
         final String bucket = System.getProperty("test.s3.bucket");

x-pack/plugin/snapshot-repo-test-kit/src/test/java/org/elasticsearch/repositories/blobstore/testkit/analyze/AbstractRepositoryAnalysisRestTestCase.java

@@ -18,6 +18,10 @@ public abstract class AbstractRepositoryAnalysisRestTestCase extends ESRestTestC
 
     protected abstract Settings repositorySettings();
 
+    protected boolean abortWritesPermitted() {
+        return true;
+    }
+
     public void testRepositoryAnalysis() throws Exception {
         final String repositoryType = repositoryType();
         final Settings repositorySettings = repositorySettings();
@@ -32,6 +36,9 @@ public void testRepositoryAnalysis() throws Exception {
         request.addParameter("max_blob_size", randomFrom("1mb", "10mb"));
         request.addParameter("timeout", "120s");
         request.addParameter("seed", Long.toString(randomLong()));
+        if (abortWritesPermitted() == false) {
+            request.addParameter("rarely_abort_writes", "false");
+        }
         assertOK(client().performRequest(request));
     }