Skip to content

Commit 4addd91

Browse files
committed
fix from review
1 parent ebf430b commit 4addd91

File tree

2 files changed

+30
-4
lines changed

2 files changed

+30
-4
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/telemetry/FeatureMetric.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
package org.elasticsearch.xpack.esql.telemetry;
99

10+
import org.elasticsearch.index.IndexMode;
1011
import org.elasticsearch.xpack.esql.EsqlIllegalArgumentException;
1112
import org.elasticsearch.xpack.esql.plan.logical.Aggregate;
1213
import org.elasticsearch.xpack.esql.plan.logical.ChangePoint;
@@ -31,7 +32,6 @@
3132
import org.elasticsearch.xpack.esql.plan.logical.Rename;
3233
import org.elasticsearch.xpack.esql.plan.logical.Row;
3334
import org.elasticsearch.xpack.esql.plan.logical.Sample;
34-
import org.elasticsearch.xpack.esql.plan.logical.TimeSeriesAggregate;
3535
import org.elasticsearch.xpack.esql.plan.logical.UnresolvedRelation;
3636
import org.elasticsearch.xpack.esql.plan.logical.fuse.Fuse;
3737
import org.elasticsearch.xpack.esql.plan.logical.fuse.FuseScoreEval;
@@ -60,8 +60,8 @@ public enum FeatureMetric {
6060
MV_EXPAND(MvExpand.class::isInstance),
6161
SHOW(ShowInfo.class::isInstance),
6262
ROW(Row.class::isInstance),
63-
FROM(EsRelation.class::isInstance),
64-
TS(TimeSeriesAggregate.class::isInstance),
63+
FROM(x -> x instanceof EsRelation relation && relation.indexMode() != IndexMode.TIME_SERIES),
64+
TS(x -> x instanceof EsRelation relation && relation.indexMode() == IndexMode.TIME_SERIES),
6565
DROP(Drop.class::isInstance),
6666
KEEP(Keep.class::isInstance),
6767
RENAME(Rename.class::isInstance),

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/telemetry/VerifierMetricsTests.java

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ public void testTimeSeriesAggregate() {
692692
assertEquals(0, mvExpand(c));
693693
assertEquals(0, show(c));
694694
assertEquals(0, row(c));
695-
assertEquals(1L, from(c));
695+
assertEquals(0, from(c));
696696
assertEquals(1L, ts(c));
697697
assertEquals(0, drop(c));
698698
assertEquals(0, keep(c));
@@ -704,6 +704,32 @@ public void testTimeSeriesAggregate() {
704704
assertEquals(1, function("avg_over_time", c));
705705
}
706706

707+
public void testTimeSeriesNoAggregate() {
708+
assumeTrue("TS required", EsqlCapabilities.Cap.TS_COMMAND_V0.isEnabled());
709+
Counters c = esql("""
710+
TS metrics
711+
| KEEP salary""");
712+
assertEquals(0, dissect(c));
713+
assertEquals(0, eval(c));
714+
assertEquals(0, grok(c));
715+
assertEquals(0, limit(c));
716+
assertEquals(0, sort(c));
717+
assertEquals(0, stats(c));
718+
assertEquals(0, where(c));
719+
assertEquals(0, enrich(c));
720+
assertEquals(0, mvExpand(c));
721+
assertEquals(0, show(c));
722+
assertEquals(0, row(c));
723+
assertEquals(0, from(c));
724+
assertEquals(1L, ts(c));
725+
assertEquals(0, drop(c));
726+
assertEquals(1L, keep(c));
727+
assertEquals(0, rename(c));
728+
assertEquals(0, inlineStats(c));
729+
assertEquals(0, lookupJoinOnFields(c));
730+
assertEquals(0, lookupJoinOnExpression(c));
731+
}
732+
707733
private long dissect(Counters c) {
708734
return c.get(FEATURES_PREFIX + DISSECT);
709735
}

0 commit comments

Comments
 (0)