Skip to content

Commit 4cd672c

Browse files
committed
This one too
1 parent 8553772 commit 4cd672c

File tree

1 file changed

+8
-20
lines changed

1 file changed

+8
-20
lines changed

server/src/main/java/org/elasticsearch/transport/TransportHandshaker.java

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,10 @@
2121
import org.elasticsearch.common.metrics.CounterMetric;
2222
import org.elasticsearch.core.Strings;
2323
import org.elasticsearch.core.TimeValue;
24-
import org.elasticsearch.core.UpdateForV9;
2524
import org.elasticsearch.logging.LogManager;
2625
import org.elasticsearch.logging.Logger;
2726
import org.elasticsearch.threadpool.ThreadPool;
2827

29-
import java.io.EOFException;
3028
import java.io.IOException;
3129
import java.util.Objects;
3230
import java.util.Set;
@@ -357,28 +355,18 @@ static final class HandshakeRequest extends TransportRequest {
357355
this.releaseVersion = Objects.requireNonNull(releaseVersion);
358356
}
359357

360-
@UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA) // remainingMessage == null is invalid in v9
361358
HandshakeRequest(StreamInput streamInput) throws IOException {
362359
super(streamInput);
363-
BytesReference remainingMessage;
364-
try {
365-
remainingMessage = streamInput.readSlicedBytesReference();
366-
} catch (EOFException e) {
367-
remainingMessage = null;
368-
}
369-
if (remainingMessage == null) {
370-
transportVersion = null;
371-
releaseVersion = null;
372-
} else {
373-
try (StreamInput messageStreamInput = remainingMessage.streamInput()) {
374-
this.transportVersion = TransportVersion.readVersion(messageStreamInput);
375-
if (streamInput.getTransportVersion().onOrAfter(V9_HANDSHAKE_VERSION)) {
376-
this.releaseVersion = messageStreamInput.readString();
377-
} else {
378-
this.releaseVersion = this.transportVersion.toReleaseVersion();
379-
}
360+
361+
try (StreamInput messageStreamInput = streamInput.readSlicedBytesReference().streamInput()) {
362+
this.transportVersion = TransportVersion.readVersion(messageStreamInput);
363+
if (streamInput.getTransportVersion().onOrAfter(V9_HANDSHAKE_VERSION)) {
364+
this.releaseVersion = messageStreamInput.readString();
365+
} else {
366+
this.releaseVersion = this.transportVersion.toReleaseVersion();
380367
}
381368
}
369+
382370
}
383371

384372
@Override

0 commit comments

Comments
 (0)