Make the test fail

Pipe should not be a valid separator in mac addresses

Author: joegallo

modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/CefParser.java

@@ -71,11 +71,11 @@ final class CefParser {
     private static final Pattern MAC_ADDRESS_PATTERN = Pattern.compile(
         Stream.of(
             // Combined colon and hyphen separated 6-group patterns
-            "(([0-9A-Fa-f]{2}[:|-]){5}[0-9A-Fa-f]{2})",
+            "(([0-9A-Fa-f]{2}[:-]){5}[0-9A-Fa-f]{2})",
             // Dot-separated 6-group pattern
             "([0-9A-Fa-f]{4}\\.){2}[0-9A-Fa-f]{4}",
             // Combined colon and hyphen separated 8-group patterns
-            "([0-9A-Fa-f]{2}[:|-]){7}[0-9A-Fa-f]{2}",
+            "([0-9A-Fa-f]{2}[:-]){7}[0-9A-Fa-f]{2}",
             // Dot-separated EUI-64
             "([0-9A-Fa-f]{4}\\.){3}[0-9A-Fa-f]{4}"
         ).collect(Collectors.joining("|", "^(", ")$"))

modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/CefProcessorTests.java

@@ -972,9 +972,8 @@ public void testToMacAddressWithSeparators() {
 
     public void testInvalidMacAddressSeparator() {
         CefParser parser = new CefParser(ZoneId.of("UTC"), false);
-        String macAddress = "00|0D|60|AF|1B|61";
-        String result = parser.toMACAddress(macAddress);
-        assertEquals("00|0D|60|AF|1B|61", result);
+        IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> parser.toMACAddress("00|0D|60|AF|1B|61"));
+        assertThat(e.getMessage(), equalTo("Invalid MAC address format"));
     }
 
     public void testEUI48ToMacAddressWithOutSeparators() {