fixing test and writing

Author: benwtrent

qa/vector/src/main/java/org/elasticsearch/test/knn/KnnIndexTester.java

@@ -211,7 +211,7 @@ public static void main(String[] args) throws Exception {
                 for (int i = 0; i < results.length; i++) {
                     int nProbe = nProbes[i];
                     KnnSearcher knnSearcher = new KnnSearcher(indexPath, cmdLineArgs, nProbe);
-                    knnSearcher.runSearch(results[i]);
+                    knnSearcher.runSearch(results[i], cmdLineArgs.earlyTermination());
                 }
             }
             formattedResults.results.addAll(List.of(results));

server/src/main/java/org/elasticsearch/index/codec/vectors/DiskBBQBulkWriter.java

@@ -58,10 +58,10 @@ private static void writeCorrections(OptimizedScalarQuantizer.QuantizationResult
     private static void writeCorrection(OptimizedScalarQuantizer.QuantizationResult correction, IndexOutput out) throws IOException {
         out.writeInt(Float.floatToIntBits(correction.lowerInterval()));
         out.writeInt(Float.floatToIntBits(correction.upperInterval()));
+        out.writeInt(Float.floatToIntBits(correction.additionalCorrection()));
         int targetComponentSum = correction.quantizedComponentSum();
         assert targetComponentSum >= 0 && targetComponentSum <= 0xffff;
         out.writeShort((short) targetComponentSum);
-        out.writeInt(Float.floatToIntBits(correction.additionalCorrection()));
     }
 
     public static class OneBitDiskBBQBulkWriter extends DiskBBQBulkWriter {

server/src/test/java/org/elasticsearch/search/vectors/AbstractDiversifyingChildrenIVFKnnVectorQueryTestCase.java

@@ -300,7 +300,7 @@ public void testSkewedIndex() throws IOException {
                 );
                 assertEquals(8, results.scoreDocs.length);
                 assertIdMatches(reader, "10", results.scoreDocs[0].doc);
-                assertIdMatches(reader, "8", results.scoreDocs[7].doc);
+                assertIdMatches(reader, "6", results.scoreDocs[7].doc);
             }
         }
     }