More

Author: n1v0lg

docs/reference/rest-api/security/get-user-privileges.asciidoc

@@ -11,7 +11,7 @@
 For the most up-to-date API details, refer to {api-es}/group/endpoint-security[Security APIs].
 --
 
-Retrieves the <<security-privileges,security privileges>> for the logged in
+Retrieves the <<security-privileges,security privileges>> for the logged in 
 user.
 
 [[security-api-get-user-privileges-request]]
@@ -22,7 +22,7 @@ user.
 [[security-api-get-user-privileges-prereqs]]
 ==== {api-prereq-title}
 
-* All users can use this API, but only to determine their own privileges. To
+* All users can use this API, but only to determine their own privileges. To 
 check the privileges of other users, you must use the run as feature. For
 more information, see <<run-as-privilege>>.
 
@@ -57,15 +57,6 @@ GET /_security/user/_privileges
         "all"
       ],
       "allow_restricted_indices" : true
-    },
-    {
-      "names" : [
-        "*::failures"
-      ],
-      "privileges" : [
-        "all"
-      ],
-      "allow_restricted_indices" : true
     }
   ],
   "applications" : [

server/src/main/java/org/elasticsearch/cluster/metadata/IndexAbstraction.java

@@ -100,7 +100,7 @@ default boolean isDataStreamRelated() {
         return false;
     }
 
-    default boolean isDataStreamConcreteFailureIndex() {
+    default boolean isConcreteFailureIndexOfDataStream() {
         return false;
     }
 
@@ -198,7 +198,7 @@ public boolean isSystem() {
         }
 
         @Override
-        public boolean isDataStreamConcreteFailureIndex() {
+        public boolean isConcreteFailureIndexOfDataStream() {
             return getParentDataStream() != null && getParentDataStream().isFailureStoreIndex(getName());
         }
 

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/permission/IndicesPermission.java

@@ -463,10 +463,10 @@ public boolean checkIndex(Group group) {
             if (ds != null) {
                 if (group.checkIndex(ds.getName())) {
                     // TODO is this right?
-                    if (indexAbstraction.isDataStreamConcreteFailureIndex()) {
-                        return group.checkSelector(IndexComponentSelector.FAILURES);
-                    }
-                    return group.checkSelector(selector);
+                    final IndexComponentSelector selectorToCheck = indexAbstraction.isConcreteFailureIndexOfDataStream()
+                        ? IndexComponentSelector.FAILURES
+                        : selector;
+                    return group.checkSelector(selectorToCheck);
                 }
             }
             if (indexAbstraction != null && indexAbstraction.getType() == IndexAbstraction.Type.DATA_STREAM) {

x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/RBACEngine.java

@@ -878,7 +878,7 @@ static AuthorizedIndices resolveAuthorizedIndicesFromRole(
             if (includeDataStreams) {
                 for (IndexAbstraction indexAbstraction : lookup.values()) {
                     // TODO this is not great ...
-                    if ((indexAbstraction.isDataStreamConcreteFailureIndex()
+                    if ((indexAbstraction.isConcreteFailureIndexOfDataStream()
                         && predicate.test(indexAbstraction.getParentDataStream(), IndexComponentSelector.FAILURES.getKey()))
                         || predicate.test(indexAbstraction, selector)) {
                         indicesAndAliases.add(indexAbstraction.getName());