Skip to content

Commit 5000d94

Browse files
authored
Remove nimbus shadow jar (#133602)
This shadow jar was necessary for SecurityManager due to its use of gson libraries. However, now that entitlements has replaced security manager, it is no longer needed.
1 parent 593212b commit 5000d94

File tree

11 files changed

+12
-782
lines changed

11 files changed

+12
-782
lines changed

x-pack/plugin/security/build.gradle

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,7 @@ dependencies {
8181
// Dependencies for oidc
8282
api "com.nimbusds:oauth2-oidc-sdk:11.22.2"
8383
runtimeOnly "com.nimbusds:content-type:2.3"
84-
api project(path: xpackModule('security:lib:nimbus-jose-jwt-modified'), configuration: 'shadow')
85-
if (isEclipse) {
86-
/*
87-
* Eclipse can't pick up the shadow dependency so we point it at the unmodified version of the library
88-
* so it can compile things.
89-
*/
90-
api "com.nimbusds:nimbus-jose-jwt:10.0.2"
91-
}
84+
api "com.nimbusds:nimbus-jose-jwt:10.0.2"
9285
api "com.nimbusds:lang-tag:1.7"
9386
api "com.sun.mail:jakarta.mail:1.6.8"
9487
api "net.jcip:jcip-annotations:1.0"
@@ -186,6 +179,7 @@ tasks.named("dependencyLicenses").configure {
186179
mapping from: /bc.*/, to: 'bouncycastle'
187180
mapping from: /failureaccess.*/, to: 'guava'
188181
mapping from: 'content-type', to: 'nimbus'
182+
mapping from: /nimbus.*/, to: 'nimbus'
189183
}
190184

191185
tasks.named("forbiddenPatterns").configure {
@@ -388,6 +382,16 @@ tasks.named("thirdPartyAudit").configure {
388382
'org.bouncycastle.util.Arrays',
389383
'org.bouncycastle.util.io.Streams',
390384
'org.bouncycastle.cert.X509CertificateHolder',
385+
// missing classes linked by nimbus
386+
'com.google.crypto.tink.subtle.Ed25519Sign',
387+
'com.google.crypto.tink.subtle.Ed25519Sign$KeyPair',
388+
'com.google.crypto.tink.subtle.Ed25519Verify',
389+
'com.google.crypto.tink.subtle.X25519',
390+
'com.google.crypto.tink.subtle.XChaCha20Poly1305',
391+
'org.bouncycastle.cert.jcajce.JcaX509CertificateHolder',
392+
'org.bouncycastle.openssl.PEMKeyPair',
393+
'org.bouncycastle.openssl.PEMParser',
394+
'org.bouncycastle.openssl.jcajce.JcaPEMKeyConverter'
391395
)
392396

393397
ignoreViolations(

x-pack/plugin/security/lib/build.gradle

Lines changed: 0 additions & 13 deletions
This file was deleted.

x-pack/plugin/security/lib/nimbus-jose-jwt-modified-part1/build.gradle

Lines changed: 0 additions & 29 deletions
This file was deleted.

x-pack/plugin/security/lib/nimbus-jose-jwt-modified-part1/licenses/nimbus-jose-jwt-LICENSE.txt

Lines changed: 0 additions & 202 deletions
This file was deleted.

x-pack/plugin/security/lib/nimbus-jose-jwt-modified-part1/licenses/nimbus-jose-jwt-NOTICE.txt

Lines changed: 0 additions & 14 deletions
This file was deleted.

x-pack/plugin/security/lib/nimbus-jose-jwt-modified-part2/build.gradle

Lines changed: 0 additions & 26 deletions
This file was deleted.

x-pack/plugin/security/lib/nimbus-jose-jwt-modified/build.gradle

Lines changed: 0 additions & 29 deletions
This file was deleted.

0 commit comments

Comments
 (0)