Skip to content

Commit 51d5196

Browse files
committed
Revert search type rewrite change
1 parent 61d40c4 commit 51d5196

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

server/src/main/java/org/elasticsearch/action/search/TransportSearchAction.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ public void onFailure(Exception e) {}
589589
);
590590
}
591591

592-
static void adjustSearchType(SearchRequest searchRequest, boolean oneOrZeroShards) {
592+
static void adjustSearchType(SearchRequest searchRequest, boolean singleShard) {
593593
// if there's a kNN search, always use DFS_QUERY_THEN_FETCH
594594
if (searchRequest.hasKnnSearch()) {
595595
searchRequest.searchType(DFS_QUERY_THEN_FETCH);
@@ -604,7 +604,7 @@ static void adjustSearchType(SearchRequest searchRequest, boolean oneOrZeroShard
604604
}
605605

606606
// optimize search type for cases where there is only one shard group to search on
607-
if (oneOrZeroShards) {
607+
if (singleShard) {
608608
// if we only have one group, then we always want Q_T_F, no need for DFS, and no need to do THEN since we hit one shard
609609
searchRequest.searchType(QUERY_THEN_FETCH);
610610
}
@@ -1305,7 +1305,7 @@ private void executeSearch(
13051305

13061306
Map<String, Float> concreteIndexBoosts = resolveIndexBoosts(searchRequest, projectState.cluster());
13071307

1308-
adjustSearchType(searchRequest, shardIterators.size() <= 1);
1308+
adjustSearchType(searchRequest, shardIterators.size() == 1);
13091309

13101310
final DiscoveryNodes nodes = projectState.cluster().nodes();
13111311
BiFunction<String, String, Transport.Connection> connectionLookup = buildConnectionLookup(

0 commit comments

Comments
 (0)