Skip to content

Commit 51f865d

Browse files
committed
Lint
1 parent 93a97ae commit 51f865d

File tree

2 files changed

+82
-66
lines changed

2 files changed

+82
-66
lines changed

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/tree/NodeInfo.java

Lines changed: 63 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -256,12 +256,12 @@ protected void innerTransform(BiConsumer<Object, ActionListener<Object>> rule, A
256256
newProps -> innerProperties().equals(newProps)
257257
? node
258258
: ctor.apply(
259-
node.source(),
260-
(P1) newProps.get(0),
261-
(P2) newProps.get(1),
262-
(P3) newProps.get(2),
263-
(P4) newProps.get(3)
264-
)
259+
node.source(),
260+
(P1) newProps.get(0),
261+
(P2) newProps.get(1),
262+
(P3) newProps.get(2),
263+
(P4) newProps.get(3)
264+
)
265265
)
266266
);
267267
}
@@ -317,13 +317,13 @@ protected void innerTransform(BiConsumer<Object, ActionListener<Object>> rule, A
317317
newProps -> innerProperties().equals(newProps)
318318
? node
319319
: ctor.apply(
320-
node.source(),
321-
(P1) newProps.get(0),
322-
(P2) newProps.get(1),
323-
(P3) newProps.get(2),
324-
(P4) newProps.get(3),
325-
(P5) newProps.get(4)
326-
)
320+
node.source(),
321+
(P1) newProps.get(0),
322+
(P2) newProps.get(1),
323+
(P3) newProps.get(2),
324+
(P4) newProps.get(3),
325+
(P5) newProps.get(4)
326+
)
327327
)
328328
);
329329
}
@@ -383,14 +383,14 @@ protected void innerTransform(BiConsumer<Object, ActionListener<Object>> rule, A
383383
newProps -> innerProperties().equals(newProps)
384384
? node
385385
: ctor.apply(
386-
node.source(),
387-
(P1) newProps.get(0),
388-
(P2) newProps.get(1),
389-
(P3) newProps.get(2),
390-
(P4) newProps.get(3),
391-
(P5) newProps.get(4),
392-
(P6) newProps.get(5)
393-
)
386+
node.source(),
387+
(P1) newProps.get(0),
388+
(P2) newProps.get(1),
389+
(P3) newProps.get(2),
390+
(P4) newProps.get(3),
391+
(P5) newProps.get(4),
392+
(P6) newProps.get(5)
393+
)
394394
)
395395
);
396396
}
@@ -454,15 +454,15 @@ protected void innerTransform(BiConsumer<Object, ActionListener<Object>> rule, A
454454
newProps -> innerProperties().equals(newProps)
455455
? node
456456
: ctor.apply(
457-
node.source(),
458-
(P1) newProps.get(0),
459-
(P2) newProps.get(1),
460-
(P3) newProps.get(2),
461-
(P4) newProps.get(3),
462-
(P5) newProps.get(4),
463-
(P6) newProps.get(5),
464-
(P7) newProps.get(6)
465-
)
457+
node.source(),
458+
(P1) newProps.get(0),
459+
(P2) newProps.get(1),
460+
(P3) newProps.get(2),
461+
(P4) newProps.get(3),
462+
(P5) newProps.get(4),
463+
(P6) newProps.get(5),
464+
(P7) newProps.get(6)
465+
)
466466
)
467467
);
468468
}
@@ -530,16 +530,16 @@ protected void innerTransform(BiConsumer<Object, ActionListener<Object>> rule, A
530530
newProps -> innerProperties().equals(newProps)
531531
? node
532532
: ctor.apply(
533-
node.source(),
534-
(P1) newProps.get(0),
535-
(P2) newProps.get(1),
536-
(P3) newProps.get(2),
537-
(P4) newProps.get(3),
538-
(P5) newProps.get(4),
539-
(P6) newProps.get(5),
540-
(P7) newProps.get(6),
541-
(P8) newProps.get(7)
542-
)
533+
node.source(),
534+
(P1) newProps.get(0),
535+
(P2) newProps.get(1),
536+
(P3) newProps.get(2),
537+
(P4) newProps.get(3),
538+
(P5) newProps.get(4),
539+
(P6) newProps.get(5),
540+
(P7) newProps.get(6),
541+
(P8) newProps.get(7)
542+
)
543543
)
544544
);
545545
}
@@ -611,17 +611,17 @@ protected void innerTransform(BiConsumer<Object, ActionListener<Object>> rule, A
611611
newProps -> innerProperties().equals(newProps)
612612
? node
613613
: ctor.apply(
614-
node.source(),
615-
(P1) newProps.get(0),
616-
(P2) newProps.get(1),
617-
(P3) newProps.get(2),
618-
(P4) newProps.get(3),
619-
(P5) newProps.get(4),
620-
(P6) newProps.get(5),
621-
(P7) newProps.get(6),
622-
(P8) newProps.get(7),
623-
(P9) newProps.get(8)
624-
)
614+
node.source(),
615+
(P1) newProps.get(0),
616+
(P2) newProps.get(1),
617+
(P3) newProps.get(2),
618+
(P4) newProps.get(3),
619+
(P5) newProps.get(4),
620+
(P6) newProps.get(5),
621+
(P7) newProps.get(6),
622+
(P8) newProps.get(7),
623+
(P9) newProps.get(8)
624+
)
625625
)
626626
);
627627
}
@@ -697,18 +697,18 @@ protected void innerTransform(BiConsumer<Object, ActionListener<Object>> rule, A
697697
newProps -> innerProperties().equals(newProps)
698698
? node
699699
: ctor.apply(
700-
node.source(),
701-
(P1) newProps.get(0),
702-
(P2) newProps.get(1),
703-
(P3) newProps.get(2),
704-
(P4) newProps.get(3),
705-
(P5) newProps.get(4),
706-
(P6) newProps.get(5),
707-
(P7) newProps.get(6),
708-
(P8) newProps.get(7),
709-
(P9) newProps.get(8),
710-
(P10) newProps.get(9)
711-
)
700+
node.source(),
701+
(P1) newProps.get(0),
702+
(P2) newProps.get(1),
703+
(P3) newProps.get(2),
704+
(P4) newProps.get(3),
705+
(P5) newProps.get(4),
706+
(P6) newProps.get(5),
707+
(P7) newProps.get(6),
708+
(P8) newProps.get(7),
709+
(P9) newProps.get(8),
710+
(P10) newProps.get(9)
711+
)
712712
)
713713
);
714714
}

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/inference/textembedding/TextEmbeddingFunctionEvaluator.java

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import org.elasticsearch.xpack.core.inference.results.TextEmbeddingBitResults;
1515
import org.elasticsearch.xpack.core.inference.results.TextEmbeddingByteResults;
1616
import org.elasticsearch.xpack.core.inference.results.TextEmbeddingFloatResults;
17+
import org.elasticsearch.xpack.core.inference.results.TextEmbeddingResults;
1718
import org.elasticsearch.xpack.esql.core.expression.Expression;
1819
import org.elasticsearch.xpack.esql.core.expression.FoldContext;
1920
import org.elasticsearch.xpack.esql.core.expression.Literal;
@@ -22,6 +23,7 @@
2223
import org.elasticsearch.xpack.esql.inference.InferenceFunctionEvaluator;
2324
import org.elasticsearch.xpack.esql.inference.InferenceRunner;
2425

26+
import java.util.ArrayList;
2527
import java.util.List;
2628

2729
public class TextEmbeddingFunctionEvaluator implements InferenceFunctionEvaluator {
@@ -51,13 +53,27 @@ private InferenceAction.Request inferenceRequest(String inferenceId, String inpu
5153
}
5254

5355
private Literal parseInferenceResponse(InferenceAction.Response response) {
54-
float[] embeddingValues = switch (response.getResults()) {
56+
if (response.getResults() instanceof TextEmbeddingResults<?> textEmbeddingResults) {
57+
return parseInferenceResponse(textEmbeddingResults);
58+
}
59+
throw new IllegalArgumentException("Inference response should be of type TextEmbeddingResults");
60+
}
61+
62+
private Literal parseInferenceResponse(TextEmbeddingResults<?> result) {
63+
List<Float> embeddingList = new ArrayList<>(result.getFirstEmbeddingSize());
64+
for (float value : getEmbeddingValues(result)) {
65+
embeddingList.add(value);
66+
}
67+
68+
return new Literal(f.source(), embeddingList, DataType.DENSE_VECTOR);
69+
}
70+
71+
private float[] getEmbeddingValues(TextEmbeddingResults<?> result) {
72+
return switch (result) {
5573
case TextEmbeddingFloatResults floatEmbeddingResults -> floatEmbeddingResults.embeddings().get(0).values();
5674
case TextEmbeddingByteResults bytesEmbeddingResults -> bytesEmbeddingResults.embeddings().get(0).toFloatArray();
5775
case TextEmbeddingBitResults bitsEmbeddingResults -> bitsEmbeddingResults.embeddings().get(0).toFloatArray();
5876
default -> throw new IllegalArgumentException("Inference response should be of type TextEmbeddingResults");
5977
};
60-
61-
return new Literal(f.source(), embeddingValues, DataType.DENSE_VECTOR);
6278
}
6379
}

0 commit comments

Comments
 (0)