mute tests, adjust some things, links to issues

Author: limotova

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/EsqlQueryGenerator.java

@@ -19,18 +19,19 @@
 import org.elasticsearch.xpack.esql.qa.rest.generative.command.pipe.KeepGenerator;
 import org.elasticsearch.xpack.esql.qa.rest.generative.command.pipe.LimitGenerator;
 import org.elasticsearch.xpack.esql.qa.rest.generative.command.pipe.LookupJoinGenerator;
-import org.elasticsearch.xpack.esql.qa.rest.generative.command.pipe.TimeSeriesStatsGenerator;
 import org.elasticsearch.xpack.esql.qa.rest.generative.command.pipe.MvExpandGenerator;
 import org.elasticsearch.xpack.esql.qa.rest.generative.command.pipe.RenameGenerator;
 import org.elasticsearch.xpack.esql.qa.rest.generative.command.pipe.SortGenerator;
 import org.elasticsearch.xpack.esql.qa.rest.generative.command.pipe.StatsGenerator;
+import org.elasticsearch.xpack.esql.qa.rest.generative.command.pipe.TimeSeriesStatsGenerator;
 import org.elasticsearch.xpack.esql.qa.rest.generative.command.pipe.WhereGenerator;
 import org.elasticsearch.xpack.esql.qa.rest.generative.command.source.FromGenerator;
 import org.elasticsearch.xpack.esql.qa.rest.generative.command.source.TimeSeriesGenerator;
 
 import java.util.List;
 import java.util.Set;
 import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 import static org.elasticsearch.test.ESTestCase.randomAlphaOfLength;
 import static org.elasticsearch.test.ESTestCase.randomBoolean;
@@ -79,24 +80,10 @@ public record QueryExecuted(String query, int depth, List<Column> outputSchema,
         WhereGenerator.INSTANCE
     );
 
-    static List<CommandGenerator> TIME_SERIES_PIPE_COMMANDS = List.of(
-        ChangePointGenerator.INSTANCE,
-        DissectGenerator.INSTANCE,
-        DropGenerator.INSTANCE,
-        EnrichGenerator.INSTANCE,
-        EvalGenerator.INSTANCE,
-        ForkGenerator.INSTANCE,
-        GrokGenerator.INSTANCE,
-        KeepGenerator.INSTANCE,
-        LimitGenerator.INSTANCE,
-        LookupJoinGenerator.INSTANCE,
-        TimeSeriesStatsGenerator.INSTANCE,
-        MvExpandGenerator.INSTANCE,
-        RenameGenerator.INSTANCE,
-        SortGenerator.INSTANCE,
-        StatsGenerator.INSTANCE,
-        WhereGenerator.INSTANCE
-    );
+    static List<CommandGenerator> TIME_SERIES_PIPE_COMMANDS = Stream.concat(
+        PIPE_COMMANDS.stream(),
+        Stream.of(TimeSeriesStatsGenerator.INSTANCE)
+    ).toList();
 
     public static CommandGenerator sourceCommand() {
         return randomFrom(SOURCE_COMMANDS);
@@ -111,7 +98,6 @@ public static CommandGenerator randomPipeCommandGenerator() {
     }
 
     public static CommandGenerator randomMetricsPipeCommandGenerator() {
-        // todo better way
         return randomFrom(TIME_SERIES_PIPE_COMMANDS);
     }
 
@@ -143,7 +129,7 @@ public static void generatePipeline(
             if (executor.currentSchema().isEmpty()) {
                 break;
             }
-            commandGenerator = isTimeSeries ? randomMetricsPipeCommandGenerator() : EsqlQueryGenerator.randomPipeCommandGenerator();
+            commandGenerator = isTimeSeries ? randomMetricsPipeCommandGenerator() : randomPipeCommandGenerator();
             desc = commandGenerator.generate(executor.previousCommands(), executor.currentSchema(), schema);
             if (desc == CommandGenerator.EMPTY_DESCRIPTION) {
                 continue;
@@ -266,7 +252,12 @@ yield switch ((randomIntBetween(0, 5))) {
                     case 0 -> "max_over_time(" + numericPlusAggMetricFieldName + ")";
                     case 1 -> "min_over_time(" + numericPlusAggMetricFieldName + ")";
                     case 2 -> "sum_over_time(" + numericPlusAggMetricFieldName + ")";
-                    case 3 -> "present_over_time(" + numericPlusAggMetricFieldName + ")";
+                    case 3 -> {
+                        if (outerCommand.equals("sum") || outerCommand.equals("avg")) {
+                            yield null;
+                        }
+                        yield "present_over_time(" + numericPlusAggMetricFieldName + ")";
+                    }
                     case 4 -> "count_over_time(" + numericPlusAggMetricFieldName + ")";
                     default -> "avg_over_time(" + numericPlusAggMetricFieldName + ")";
                 };
@@ -287,6 +278,13 @@ yield switch ((randomIntBetween(0, 5))) {
                 if (numericFieldName == null) {
                     yield null;
                 }
+                if (previousOutput.stream()
+                    .noneMatch(
+                        column -> column.name.equals("@timestamp") && (column.type.equals("date_nanos") || column.type.equals("datetime"))
+                    )) {
+                    // first_over_time and last_over_time require @timestamp to be available and be either datetime or date_nanos
+                    yield null;
+                }
                 yield (randomBoolean() ? "first_over_time(" : "last_over_time(") + numericFieldName + ")";
             }
             default -> {

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/GenerativeRestTest.java

@@ -62,7 +62,12 @@ public abstract class GenerativeRestTest extends ESRestTestCase {
         "optimized incorrectly due to missing references", // https://github.com/elastic/elasticsearch/issues/131509
 
         // Awaiting fixes for correctness
-        "Expecting at most \\[.*\\] columns, got \\[.*\\]" // https://github.com/elastic/elasticsearch/issues/129561
+        "Expecting at most \\[.*\\] columns, got \\[.*\\]", // https://github.com/elastic/elasticsearch/issues/129561
+
+        // TS-command tests
+        "Invalid call to dataType on an unresolved object \\?LASTOVERTIME", // https://github.com/elastic/elasticsearch/issues/134791
+        "class org.elasticsearch.compute.data..*Block cannot be cast to class org.elasticsearch.compute.data..*Block", // https://github.com/elastic/elasticsearch/issues/134793
+        "Output has changed from \\[.*\\] to \\[.*\\]" // https://github.com/elastic/elasticsearch/issues/134794
     );
 
     public static final Set<Pattern> ALLOWED_ERROR_PATTERNS = ALLOWED_ERRORS.stream()

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/command/pipe/TimeSeriesStatsGenerator.java

@@ -81,12 +81,9 @@ public CommandDescription generate(
             }
         }
         // TODO: add alternative time buckets
-        cmd.append(
-            (randomBoolean() ? EsqlQueryGenerator.randomIdentifier() : EsqlQueryGenerator.randomName(previousOutput))
-                + " = bucket("
-                + timestamp
-                + ",1hour)"
-        );
+        // TODO: replace name of bucket with half chance of being EsqlQueryGenerator.randomName(previousOutput) if
+        // is fixed https://github.com/elastic/elasticsearch/issues/134796
+        cmd.append(EsqlQueryGenerator.randomIdentifier() + " = bucket(" + timestamp + ",1hour)");
         return new CommandDescription(STATS, this, cmd.toString(), Map.of());
     }