Words are good

Author: nik9000

server/src/main/java/org/elasticsearch/rest/RestResponse.java

@@ -127,7 +127,7 @@ public RestResponse(RestChannel channel, RestStatus status, Exception e) throws
         ToXContent.Params params = channel.request();
         if (e != null) {
             Level level = status.getStatus() < 500 || ExceptionsHelper.isNodeOrShardUnavailableTypeException(e) ? Level.DEBUG : Level.WARN;
-            suppressedError(level, channel.request().rawPath(), channel.request().params(), status, e);
+            logSuppressedError(level, channel.request().rawPath(), channel.request().params(), status, e);
         }
         // if "error_trace" is turned on in the request, we want to render it in the rest response
         // for that the REST_EXCEPTION_SKIP_STACK_TRACE flag that if "true" omits the stack traces is
@@ -245,7 +245,10 @@ public void close() {
         Releasables.closeExpectNoException(releasable);
     }
 
-    public static void suppressedError(Level level, String rawPath, Map<String, String> params, RestStatus status, Exception e) {
+    /**
+     * Log failures to the {@code rest.suppressed} logger.
+     */
+    public static void logSuppressedError(Level level, String rawPath, Map<String, String> params, RestStatus status, Exception e) {
         if (SUPPRESSED_ERROR_LOGGER.isEnabled(level)) {
             SUPPRESSED_ERROR_LOGGER.log(
                 level,

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlResponseListener.java

@@ -123,7 +123,7 @@ private EsqlResponseListener(RestChannel channel, RestRequest restRequest, Strin
 
     @Override
     protected void processResponse(EsqlQueryResponse esqlQueryResponse) throws IOException {
-        logPartialResponseErrors(channel.request().rawPath(), channel.request().params(), esqlQueryResponse.getExecutionInfo());
+        logPartialFailures(channel.request().rawPath(), channel.request().params(), esqlQueryResponse.getExecutionInfo());
         channel.sendResponse(buildResponse(esqlQueryResponse));
     }
 
@@ -233,10 +233,14 @@ private void checkDelimiter() {
         }
     }
 
-    static void logPartialResponseErrors(String rawPath, Map<String, String> params, EsqlExecutionInfo exeuctionInfo) {
+    /**
+     * Log all partial request failures to the {@code rest.suppressed} logger
+     * so an operator can categorize them after the fact.
+     */
+    static void logPartialFailures(String rawPath, Map<String, String> params, EsqlExecutionInfo exeuctionInfo) {
         for (EsqlExecutionInfo.Cluster cluster : exeuctionInfo.getClusters().values()) {
             for (ShardSearchFailure failure : cluster.getFailures()) {
-                RestResponse.suppressedError(org.apache.logging.log4j.Level.WARN, rawPath, params, RestStatus.OK, failure);
+                RestResponse.logSuppressedError(org.apache.logging.log4j.Level.WARN, rawPath, params, RestStatus.OK, failure);
             }
         }
     }

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/action/EsqlResponseListenerTests.java

@@ -70,7 +70,7 @@ public void testLogPartialResponseErrors() {
                 new TimeValue(4444L)
             )
         );
-        EsqlResponseListener.logPartialResponseErrors("/_query", Map.of(), executionInfo);
+        EsqlResponseListener.logPartialFailures("/_query", Map.of(), executionInfo);
 
         LogEvent logEvent = appender.events.get(0);
         assertThat(logEvent.getLevel(), equalTo(Level.WARN));