sanity check

Author: limotova

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/AggregateMetricDoubleArrayBlock.java

@@ -7,6 +7,7 @@
 
 package org.elasticsearch.compute.data;
 
+import org.apache.lucene.util.RamUsageEstimator;
 import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.common.unit.ByteSizeValue;
@@ -24,6 +25,8 @@ public final class AggregateMetricDoubleArrayBlock extends AbstractNonThreadSafe
     private final IntBlock countBlock;
     private final int positionCount;
 
+    static final long BASE_RAM_BYTES_USED = RamUsageEstimator.shallowSizeOfInstance(AggregateMetricDoubleArrayBlock.class);
+
     public AggregateMetricDoubleArrayBlock(DoubleBlock minBlock, DoubleBlock maxBlock, DoubleBlock sumBlock, IntBlock countBlock) {
         this.minBlock = minBlock;
         this.maxBlock = maxBlock;
@@ -242,7 +245,18 @@ public static Block readFrom(StreamInput in) throws IOException {
 
     @Override
     public long ramBytesUsed() {
-        return minBlock.ramBytesUsed() + maxBlock.ramBytesUsed() + sumBlock.ramBytesUsed() + countBlock.ramBytesUsed();
+        // 40
+        System.err.println("BASE RAM BYTES " + BASE_RAM_BYTES_USED);
+        // 144 * 3
+        System.err.println("BLOCK BYTES USED " + minBlock.ramBytesUsed());
+        System.err.println("BLOCK BYTES USED " + maxBlock.ramBytesUsed());
+        System.err.println("BLOCK BYTES USED " + sumBlock.ramBytesUsed());
+        // 152 == 584 + 40 == 624
+        System.err.println("BLOCK BYTES USED " + countBlock.ramBytesUsed());
+        return
+//            BASE_RAM_BYTES_USED +
+                minBlock.ramBytesUsed() + maxBlock.ramBytesUsed() + sumBlock.ramBytesUsed() + countBlock
+            .ramBytesUsed();
     }
 
     @Override
@@ -289,4 +303,9 @@ public Block getMetricBlock(int index) {
         }
         throw new UnsupportedOperationException("Received an index (" + index + ") outside of range for AggregateMetricDoubleBlock.");
     }
+
+    @Override
+    public String toString() {
+        return "Min: " + minBlock + " \nMax: " + maxBlock + "\nSum: " + sumBlock + "\nCount: " + countBlock + "\n\n";
+    }
 }

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/AggregateMetricDoubleBlockBuilder.java

@@ -58,6 +58,11 @@ protected int elementSize() {
         throw new UnsupportedOperationException("Not available on aggregate_metric_double");
     }
 
+    @Override
+    public long estimatedBytes() {
+        return minBuilder.estimatedBytes() + maxBuilder.estimatedBytes() + sumBuilder.estimatedBytes() + countBuilder.estimatedBytes();
+    }
+
     @Override
     public AggregateMetricDoubleBlockBuilder copyFrom(Block b, int beginInclusive, int endExclusive) {
         Block minBlock;
@@ -83,6 +88,36 @@ public AggregateMetricDoubleBlockBuilder copyFrom(Block b, int beginInclusive, i
         return this;
     }
 
+    public AggregateMetricDoubleBlockBuilder copyFrom(AggregateMetricDoubleBlock block, int position) {
+        if (block.isNull(position)) {
+            appendNull();
+            return this;
+        }
+        // multivalue support?
+
+        if (block.minBlock().isNull(position)) {
+            min().appendNull();
+        } else {
+            min().appendDouble(block.minBlock().getDouble(position));
+        }
+        if (block.maxBlock().isNull(position)) {
+            max().appendNull();
+        } else {
+            max().appendDouble(block.maxBlock().getDouble(position));
+        }
+        if (block.sumBlock().isNull(position)) {
+            sum().appendNull();
+        } else {
+            sum().appendDouble(block.sumBlock().getDouble(position));
+        }
+        if (block.countBlock().isNull(position)) {
+            count().appendNull();
+        } else {
+            count().appendInt(block.countBlock().getInt(position));
+        }
+        return this;
+    }
+
     @Override
     public AggregateMetricDoubleBlockBuilder appendNull() {
         minBuilder.appendNull();

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/BlockFactory.java

@@ -441,30 +441,43 @@ public final AggregateMetricDoubleBlock newConstantAggregateMetricDoubleBlock(
         int positions
     ) {
         try (AggregateMetricDoubleBlockBuilder builder = newAggregateMetricDoubleBlockBuilder(positions)) {
-            if (value.min() != null) {
-                builder.min().appendDouble(value.min());
-            } else {
-                builder.min().appendNull();
-            }
-            if (value.max() != null) {
-                builder.max().appendDouble(value.max());
-            } else {
-                builder.max().appendNull();
-            }
-            if (value.sum() != null) {
-                builder.sum().appendDouble(value.sum());
-            } else {
-                builder.sum().appendNull();
-            }
-            if (value.count() != null) {
-                builder.count().appendInt(value.count());
-            } else {
-                builder.count().appendNull();
+            for (int i = 0; i < positions; i++) {
+                if (value.min() != null) {
+                    builder.min().appendDouble(value.min());
+                } else {
+                    builder.min().appendNull();
+                }
+                if (value.max() != null) {
+                    builder.max().appendDouble(value.max());
+                } else {
+                    builder.max().appendNull();
+                }
+                if (value.sum() != null) {
+                    builder.sum().appendDouble(value.sum());
+                } else {
+                    builder.sum().appendNull();
+                }
+                if (value.count() != null) {
+                    builder.count().appendInt(value.count());
+                } else {
+                    builder.count().appendNull();
+                }
             }
             return builder.build();
         }
     }
 
+    public final AggregateMetricDoubleBlock newAggregateMetricDoubleBlock(
+        double[] minValues, double[] maxValues, double[] sumValues, int[] countValues, int positions
+    ) {
+        // currently only in tests, might need to add to equality tests...
+        DoubleBlock min = newDoubleArrayVector(minValues, positions).asBlock();
+        DoubleBlock max = newDoubleArrayVector(maxValues, positions).asBlock();
+        DoubleBlock sum = newDoubleArrayVector(sumValues, positions).asBlock();
+        IntBlock count = newIntArrayVector(countValues, positions).asBlock();
+        return new AggregateMetricDoubleArrayBlock(min, max, sum, count);
+    }
+
     /**
      * Returns the maximum number of bytes that a Block should be backed by a primitive array before switching to using BigArrays.
      */