Skip to content

Commit 544ed20

Browse files
Add check for empty or unchanged task settings in OpenShift AI rerank task settings
1 parent 8813936 commit 544ed20

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/openshiftai/rerank/OpenShiftAiRerankTaskSettings.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@ public static OpenShiftAiRerankTaskSettings of(
7070
OpenShiftAiRerankTaskSettings originalSettings,
7171
OpenShiftAiRerankTaskSettings requestTaskSettings
7272
) {
73+
if (requestTaskSettings.isEmpty() || originalSettings.equals(requestTaskSettings)) {
74+
return originalSettings;
75+
}
7376
return new OpenShiftAiRerankTaskSettings(
7477
requestTaskSettings.getTopN() != null ? requestTaskSettings.getTopN() : originalSettings.getTopN(),
7578
requestTaskSettings.getReturnDocuments() != null
@@ -86,6 +89,9 @@ public static OpenShiftAiRerankTaskSettings of(
8689
* @return a constructed {@link OpenShiftAiRerankTaskSettings}
8790
*/
8891
public static OpenShiftAiRerankTaskSettings of(@Nullable Integer topN, @Nullable Boolean returnDocuments) {
92+
if (topN == null && returnDocuments == null) {
93+
return EMPTY_SETTINGS;
94+
}
8995
return new OpenShiftAiRerankTaskSettings(topN, returnDocuments);
9096
}
9197

0 commit comments

Comments
 (0)