Close stuff (makes unit test pass)

jan-elastic · jan-elastic · commit 5674046950fb · 2024-10-24T13:19:45.000+02:00
diff --git a/x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/blockhash/CategorizeRawBlockHash.java b/x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/blockhash/CategorizeRawBlockHash.java
@@ -61,7 +61,7 @@ public BitArray seenGroupIds(BigArrays bigArrays) {
 
     @Override
     public void close() {
-        // TODO
+        evaluator.close();
     }
 
     /**
@@ -102,7 +102,9 @@ public Block eval(BytesRefBlock vBlock) {
             if (vVector == null) {
                 return eval(vBlock.getPositionCount(), vBlock);
             }
-            return eval(vBlock.getPositionCount(), vVector).asBlock();
+            try (IntVector vector = eval(vBlock.getPositionCount(), vVector)) {
+                return vector.asBlock();
+            }
         }
 
         public IntBlock eval(int positionCount, BytesRefBlock vBlock) {

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public BitArray seenGroupIds(BigArrays bigArrays) {`
`61`	`61`
`62`	`62`	`@Override`
`63`	`63`	`public void close() {`
`64`		`- // TODO`
	`64`	`+ evaluator.close();`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`/**`
`@@ -102,7 +102,9 @@ public Block eval(BytesRefBlock vBlock) {`
`102`	`102`	`if (vVector == null) {`
`103`	`103`	`return eval(vBlock.getPositionCount(), vBlock);`
`104`	`104`	`}`
`105`		`- return eval(vBlock.getPositionCount(), vVector).asBlock();`
	`105`	`+ try (IntVector vector = eval(vBlock.getPositionCount(), vVector)) {`
	`106`	`+ return vector.asBlock();`
	`107`	`+ }`
`106`	`108`	`}`
`107`	`109`
`108`	`110`	`public IntBlock eval(int positionCount, BytesRefBlock vBlock) {`