Remove feature flag from xpack main code

Author: jbaiera

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/datastreams/DataStreamFeatureSetUsage.java

@@ -50,13 +50,11 @@ protected void innerXContent(XContentBuilder builder, Params params) throws IOEx
         super.innerXContent(builder, params);
         builder.field("data_streams", streamStats.totalDataStreamCount);
         builder.field("indices_count", streamStats.indicesBehindDataStream);
-        if (DataStream.isFailureStoreFeatureFlagEnabled()) {
-            builder.startObject("failure_store");
-            builder.field("explicitly_enabled_count", streamStats.failureStoreExplicitlyEnabledDataStreamCount);
-            builder.field("effectively_enabled_count", streamStats.failureStoreEffectivelyEnabledDataStreamCount);
-            builder.field("failure_indices_count", streamStats.failureStoreIndicesCount);
-            builder.endObject();
-        }
+        builder.startObject("failure_store");
+        builder.field("explicitly_enabled_count", streamStats.failureStoreExplicitlyEnabledDataStreamCount);
+        builder.field("effectively_enabled_count", streamStats.failureStoreEffectivelyEnabledDataStreamCount);
+        builder.field("failure_indices_count", streamStats.failureStoreIndicesCount);
+        builder.endObject();
     }
 
     @Override

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/action/role/RoleDescriptorRequestValidator.java

@@ -55,10 +55,8 @@ public static ActionRequestValidationException validate(
                 } catch (IllegalArgumentException ile) {
                     validationException = addValidationError(ile.getMessage(), validationException);
                 }
-                if (DataStream.isFailureStoreFeatureFlagEnabled()) {
-                    for (final String indexName : idp.getIndices()) {
-                        validationException = validateIndexNameExpression(indexName, validationException);
-                    }
+                for (final String indexName : idp.getIndices()) {
+                    validationException = validateIndexNameExpression(indexName, validationException);
                 }
             }
         }
@@ -78,10 +76,8 @@ public static ActionRequestValidationException validate(
             } catch (IllegalArgumentException ile) {
                 validationException = addValidationError(ile.getMessage(), validationException);
             }
-            if (DataStream.isFailureStoreFeatureFlagEnabled()) {
-                for (String indexName : ridp.indicesPrivileges().getIndices()) {
-                    validationException = validateIndexNameExpression(indexName, validationException);
-                }
+            for (String indexName : ridp.indicesPrivileges().getIndices()) {
+                validationException = validateIndexNameExpression(indexName, validationException);
             }
         }
         if (roleDescriptor.hasRemoteClusterPermissions()) {

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/AuthorizationEngine.java

@@ -348,17 +348,15 @@ public ActionRequestValidationException validate(ActionRequestValidationExceptio
                             validationException
                         );
                     }
-                    if (DataStream.isFailureStoreFeatureFlagEnabled()) {
-                        // best effort prevent users from attempting to use selectors in privilege check
-                        for (String indexPattern : indicesPrivileges.getIndices()) {
-                            if (IndexNameExpressionResolver.hasSelector(indexPattern, IndexComponentSelector.FAILURES)
-                                || IndexNameExpressionResolver.hasSelector(indexPattern, IndexComponentSelector.DATA)) {
-                                validationException = addValidationError(
-                                    "may only check index privileges without selectors in index patterns [" + indexPattern + "]",
-                                    validationException
-                                );
-                                break;
-                            }
+                    // best effort prevent users from attempting to use selectors in privilege check
+                    for (String indexPattern : indicesPrivileges.getIndices()) {
+                        if (IndexNameExpressionResolver.hasSelector(indexPattern, IndexComponentSelector.FAILURES)
+                            || IndexNameExpressionResolver.hasSelector(indexPattern, IndexComponentSelector.DATA)) {
+                            validationException = addValidationError(
+                                "may only check index privileges without selectors in index patterns [" + indexPattern + "]",
+                                validationException
+                            );
+                            break;
                         }
                     }
                 }

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/privilege/IndexPrivilege.java

@@ -239,9 +239,9 @@ public final class IndexPrivilege extends Privilege {
     private static final Map<String, IndexPrivilege> VALUES = combineSortedInOrder(
         sortByAccessLevel(
             Stream.of(
-                DataStream.isFailureStoreFeatureFlagEnabled() ? entry("read_failure_store", READ_FAILURE_STORE) : null,
-                DataStream.isFailureStoreFeatureFlagEnabled() ? entry("manage_failure_store", MANAGE_FAILURE_STORE) : null
-            ).filter(Objects::nonNull).collect(Collectors.toUnmodifiableMap(Map.Entry::getKey, Map.Entry::getValue))
+                entry("read_failure_store", READ_FAILURE_STORE),
+                entry("manage_failure_store", MANAGE_FAILURE_STORE)
+            ).collect(Collectors.toUnmodifiableMap(Map.Entry::getKey, Map.Entry::getValue))
         ),
         sortByAccessLevel(
             Stream.of(

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/user/InternalUsers.java

@@ -161,7 +161,7 @@ public class InternalUsers {
                     .privileges(
                         filterNonNull(
                             // needed to rollover failure store
-                            DataStream.isFailureStoreFeatureFlagEnabled() ? "manage_failure_store" : null,
+                            "manage_failure_store",
                             "delete_index",
                             RolloverAction.NAME,
                             ForceMergeAction.NAME + "*",
@@ -184,7 +184,7 @@ public class InternalUsers {
                     .privileges(
                         filterNonNull(
                             // needed to rollover failure store
-                            DataStream.isFailureStoreFeatureFlagEnabled() ? "manage_failure_store" : null,
+                            "manage_failure_store",
                             "delete_index",
                             RolloverAction.NAME,
                             ForceMergeAction.NAME + "*",
@@ -262,7 +262,7 @@ public class InternalUsers {
                     .privileges(
                         filterNonNull(
                             // needed to rollover failure store
-                            DataStream.isFailureStoreFeatureFlagEnabled() ? "manage_failure_store" : null,
+                            "manage_failure_store",
                             LazyRolloverAction.NAME
                         )
                     )

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java

@@ -948,7 +948,7 @@ public enum Cap {
         /**
          * Index component selector syntax (my-data-stream-name::failures)
          */
-        INDEX_COMPONENT_SELECTORS(DataStream.isFailureStoreFeatureFlagEnabled()),
+        INDEX_COMPONENT_SELECTORS,
 
         /**
          * Make numberOfChannels consistent with layout in DefaultLayout by removing duplicated ChannelSet.