Fix compilation error

Author: GalLalouche

plugins/discovery-ec2/src/test/java/org/elasticsearch/discovery/ec2/EC2RetriesTests.java

@@ -47,7 +47,6 @@ public class EC2RetriesTests extends AbstractEC2MockAPITestCase {
     @Override
     protected MockTransportService createTransportService() {
         return MockTransportService.createMockTransportService(
-            Settings.EMPTY,
             new Netty4Transport(
                 Settings.EMPTY,
                 TransportVersion.current(),

plugins/discovery-ec2/src/test/java/org/elasticsearch/discovery/ec2/Ec2DiscoveryTests.java

@@ -78,12 +78,7 @@ public TransportAddress[] addressesFromString(String address) {
                 return new TransportAddress[] { poorMansDNS.getOrDefault(address, buildNewFakeTransportAddress()) };
             }
         };
-        return MockTransportService.createMockTransportService(
-            Settings.EMPTY,
-            transport,
-            threadPool,
-            TransportService.NOOP_TRANSPORT_INTERCEPTOR
-        );
+        return MockTransportService.createMockTransportService(transport, threadPool);
     }
 
     protected List<TransportAddress> buildDynamicHosts(Settings nodeSettings, int nodes) {

server/src/test/java/org/elasticsearch/discovery/FileBasedSeedHostsProviderTests.java

@@ -86,7 +86,7 @@ public BoundTransportAddress boundAddress() {
                 );
             }
         };
-        transportService = MockTransportService.createMockTransportService(Settings.EMPTY, transport, threadPool);
+        transportService = MockTransportService.createMockTransportService(transport, threadPool);
     }
 
     public void testBuildDynamicNodes() throws Exception {

test/framework/src/main/java/org/elasticsearch/test/transport/MockTransportService.java

@@ -218,16 +218,16 @@ public static MockTransportService getInstance(String nodeName) {
     private final EsThreadPoolExecutor testExecutor;
 
     /** Build the service. */
-    public static MockTransportService createMockTransportService(Settings settings, Transport transport, ThreadPool threadPool) {
-        String nodeId = settings.get(Node.NODE_NAME_SETTING.getKey(), UUIDs.randomBase64UUID());
+    public static MockTransportService createMockTransportService(Transport transport, ThreadPool threadPool) {
+        String nodeId = UUIDs.randomBase64UUID();
         return new MockTransportService(
-            settings,
+            Settings.EMPTY,
             new StubbableTransport(transport),
             threadPool,
             TransportService.NOOP_TRANSPORT_INTERCEPTOR,
-            (boundAddress) -> DiscoveryNodeUtils.builder(nodeId).applySettings(settings).address(boundAddress.publishAddress()).build(),
+            (boundAddress) -> DiscoveryNodeUtils.builder(nodeId).address(boundAddress.publishAddress()).build(),
             null, // clusterSettings
-            createTaskManager(settings, threadPool, Set.of(), Tracer.NOOP, nodeId)
+            createTaskManager(Settings.EMPTY, threadPool, Set.of(), Tracer.NOOP, nodeId)
         );
     }