Remove cosine similarity code

Author: carlosdelest

server/src/main/java/org/elasticsearch/index/mapper/BlockDocValuesReader.java

@@ -536,13 +536,8 @@ public AllReader reader(LeafReaderContext context) throws IOException {
                 case FLOAT -> {
                     FloatVectorValues floatVectorValues = context.reader().getFloatVectorValues(fieldName);
                     if (floatVectorValues != null) {
-                        if (fieldType.isNormalized()) {
-                            NumericDocValues magnitudeDocValues = context.reader()
-                                .getNumericDocValues(fieldType.name() + COSINE_MAGNITUDE_FIELD_SUFFIX);
-                            return new FloatDenseVectorNormalizedValuesBlockReader(floatVectorValues, dimensions, magnitudeDocValues);
-                        }
+                        return new FloatDenseVectorValuesBlockReader(floatVectorValues, dimensions);
                     }
-                    return new FloatDenseVectorValuesBlockReader(floatVectorValues, dimensions);
                 }
                 case BYTE -> {
                     ByteVectorValues byteVectorValues = context.reader().getByteVectorValues(fieldName);
@@ -625,41 +620,6 @@ public String toString() {
         }
     }
 
-    private static class FloatDenseVectorNormalizedValuesBlockReader extends DenseVectorValuesBlockReader<FloatVectorValues> {
-        private final NumericDocValues magnitudeDocValues;
-
-        FloatDenseVectorNormalizedValuesBlockReader(
-            FloatVectorValues floatVectorValues,
-            int dimensions,
-            NumericDocValues magnitudeDocValues
-        ) {
-            super(floatVectorValues, dimensions);
-            this.magnitudeDocValues = magnitudeDocValues;
-        }
-
-        @Override
-        protected void appendDoc(BlockLoader.FloatBuilder builder) throws IOException {
-            float[] floats = vectorValues.vectorValue(iterator.index());
-            assert floats.length == dimensions
-                : "unexpected dimensions for vector value; expected " + dimensions + " but got " + floats.length;
-
-            float magnitude = 1.0f;
-            // If all vectors are normalized, no doc values will be present. The vector may be normalized already, so we may not have a
-            // stored magnitude for all docs
-            if ((magnitudeDocValues != null) && magnitudeDocValues.advanceExact(iterator.docID())) {
-                magnitude = Float.intBitsToFloat((int) magnitudeDocValues.longValue());
-            }
-            for (float aFloat : floats) {
-                builder.appendFloat(aFloat * magnitude);
-            }
-        }
-
-        @Override
-        public String toString() {
-            return "BlockDocValuesReader.FloatDenseVectorNormalizedValuesBlockReader";
-        }
-    }
-
     private static class ByteDenseVectorValuesBlockReader extends DenseVectorValuesBlockReader<ByteVectorValues> {
         ByteDenseVectorValuesBlockReader(ByteVectorValues floatVectorValues, int dimensions) {
             super(floatVectorValues, dimensions);

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/DenseVectorFieldTypeIT.java

@@ -66,7 +66,9 @@ public static Iterable<Object[]> parameters() throws Exception {
             ? randomFrom(ALL_DENSE_VECTOR_INDEX_TYPES)
             : randomFrom(NON_QUANTIZED_DENSE_VECTOR_INDEX_TYPES);
         Supplier<DenseVectorFieldMapper.VectorSimilarity> vectorSimilarityProvider = () -> randomFrom(
-            DenseVectorFieldMapper.VectorSimilarity.values()
+            DenseVectorFieldMapper.VectorSimilarity.DOT_PRODUCT,
+            DenseVectorFieldMapper.VectorSimilarity.L2_NORM,
+            DenseVectorFieldMapper.VectorSimilarity.MAX_INNER_PRODUCT
         );
         params.add(new Object[] { elementTypeProvider, indexTypeProvider, vectorSimilarityProvider, true, false });
         // No indexing
@@ -137,10 +139,6 @@ public void testRetrieveDenseVectorFieldData() {
             | KEEP id, vector
             """;
 
-        indexedVectors.forEach((i, v) -> {
-            System.out.println("ID: " + i + ", Vector: " + v);
-        });
-
         try (var resp = run(query)) {
             List<List<Object>> valuesList = EsqlTestUtils.getValuesList(resp);
             assertEquals(valuesList.size(), indexedVectors.size());