Skip to content

Commit 589770e

Browse files
committed
[Profiling] Omit address in grouping for unknown function but known executable
This reduces the complexity of the flamegraph in unsymbolized areas. Symbolized areas of the flamegraph are not affected.
1 parent eeace58 commit 589770e

File tree

1 file changed

+4
-1
lines changed
  • x-pack/plugin/profiling/src/main/java/org/elasticsearch/xpack/profiling/action

1 file changed

+4
-1
lines changed

x-pack/plugin/profiling/src/main/java/org/elasticsearch/xpack/profiling/action/FrameGroupID.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@ public static String getBasenameAndParent(String fullPath) {
3030

3131
public static String create(String fileId, Integer addressOrLine, String exeFilename, String sourceFilename, String functionName) {
3232
if (Strings.isEmpty(functionName)) {
33-
return Integer.toString(Objects.hash(fileId, addressOrLine));
33+
if (Strings.isEmpty(exeFilename)) {
34+
return Integer.toString(Objects.hash(fileId, addressOrLine));
35+
}
36+
return Integer.toString(Objects.hash(exeFilename));
3437
}
3538
if (Strings.isEmpty(sourceFilename)) {
3639
return Integer.toString(Objects.hash(fileId, functionName));

0 commit comments

Comments
 (0)