Improve tests, remove unsigned long

Author: carlosdelest

x-pack/plugin/esql/src/main/generated/org/elasticsearch/xpack/esql/expression/function/scalar/convert/ToDenseVectorFromUnsignedLongEvaluator.java

@@ -28,9 +28,7 @@
 import static org.elasticsearch.xpack.esql.core.type.DataType.KEYWORD;
 import static org.elasticsearch.xpack.esql.core.type.DataType.LONG;
 import static org.elasticsearch.xpack.esql.core.type.DataType.TEXT;
-import static org.elasticsearch.xpack.esql.core.type.DataType.UNSIGNED_LONG;
 import static org.elasticsearch.xpack.esql.type.EsqlDataTypeConverter.stringToDouble;
-import static org.elasticsearch.xpack.esql.type.EsqlDataTypeConverter.unsignedLongToDouble;
 
 public class ToDenseVector extends AbstractConvertFunction {
     public static final NamedWriteableRegistry.Entry ENTRY = new NamedWriteableRegistry.Entry(
@@ -43,7 +41,6 @@ public class ToDenseVector extends AbstractConvertFunction {
         Map.entry(DENSE_VECTOR, (source, fieldEval) -> fieldEval),
         Map.entry(KEYWORD, ToDenseVectorFromStringEvaluator.Factory::new),
         Map.entry(TEXT, ToDenseVectorFromStringEvaluator.Factory::new),
-        Map.entry(UNSIGNED_LONG, ToDenseVectorFromUnsignedLongEvaluator.Factory::new),
         Map.entry(LONG, ToDenseVectorFromLongEvaluator.Factory::new),
         Map.entry(INTEGER, ToDenseVectorFromIntEvaluator.Factory::new),
         Map.entry(DOUBLE, ToDenseVectorFromDoubleEvaluator.Factory::new)
@@ -57,7 +54,7 @@ public ToDenseVector(
         Source source,
         @Param(
             name = "field",
-            type = { "keyword", "text", "double", "long", "unsigned_long", "integer", "float" },
+            type = { "keyword", "text", "double", "long", "integer" },
             description = "Input multi-valued column or an expression."
         ) Expression field
     ) {
@@ -98,11 +95,6 @@ static float fromString(BytesRef in) {
         return (float) stringToDouble(in.utf8ToString());
     }
 
-    @ConvertEvaluator(extraName = "FromUnsignedLong")
-    static float fromUnsignedLong(long l) {
-        return (float) unsignedLongToDouble(l);
-    }
-
     @ConvertEvaluator(extraName = "FromLong")
     static float fromLong(long l) {
         return l;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/ToDenseVector.java

@@ -9,14 +9,17 @@
 
 import com.carrotsearch.randomizedtesting.annotations.Name;
 import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
+
 import org.apache.lucene.util.BytesRef;
+import org.elasticsearch.test.ESTestCase;
 import org.elasticsearch.xpack.esql.core.expression.Expression;
 import org.elasticsearch.xpack.esql.core.tree.Source;
 import org.elasticsearch.xpack.esql.core.type.DataType;
 import org.elasticsearch.xpack.esql.expression.function.AbstractScalarFunctionTestCase;
 import org.elasticsearch.xpack.esql.expression.function.TestCaseSupplier;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 import java.util.function.Supplier;
 
@@ -36,41 +39,46 @@ public static Iterable<Object[]> parameters() {
             new TestCaseSupplier(
                 "int",
                 List.of(DataType.INTEGER),
-                () -> new TestCaseSupplier.TestCase(
-                    List.of(
-                        new TestCaseSupplier.TypedData(
-                            1,
-                            DataType.INTEGER,
-                            "int"
-                        )
-                    ),
-                    evaluatorName("Int", "i"),
-                    DataType.DENSE_VECTOR,
-                    equalTo(1.0f)
-                )
+                () -> {
+                    List<Integer> data = Arrays.asList(randomArray(1, 10, Integer[]::new, ESTestCase::randomInt));
+                    return new TestCaseSupplier.TestCase(
+                        List.of(
+                            new TestCaseSupplier.TypedData(
+                                data,
+                                DataType.INTEGER,
+                                "int"
+                            )
+                        ),
+                        evaluatorName("Int", "i"),
+                        DataType.DENSE_VECTOR,
+                        equalTo(data.stream().map(Number::floatValue).toList())
+                    );
+                }
             )
         );
 
-        // Multi-valued inputs
         suppliers.add(
             new TestCaseSupplier(
-                "mv_long",
+                "long",
                 List.of(DataType.LONG),
-                () -> new TestCaseSupplier.TestCase(
-                    List.of(
-                        new TestCaseSupplier.TypedData(
-                            List.of(1L, 2L, 3L),
-                            DataType.LONG,
-                            "mv_long"
-                        )
-                    ),
-                    evaluatorName("Long", "l"),
-                    DataType.DENSE_VECTOR,
-                    equalTo(List.of(1.0f, 2.0f, 3.0f))
-                )
+                () -> {
+                    List<Long> data = Arrays.asList(randomArray(1, 10, Long[]::new, ESTestCase::randomLong));
+                    return new TestCaseSupplier.TestCase(
+                        List.of(
+                            new TestCaseSupplier.TypedData(
+                                data,
+                                DataType.LONG,
+                                "long"
+                            )
+                        ),
+                        evaluatorName("Long", "l"),
+                        DataType.DENSE_VECTOR,
+                        equalTo(data.stream().map(Number::floatValue).toList())
+                    );
+                }
             )
         );
-        
+
         suppliers.add(
             new TestCaseSupplier(
                 "mv_string",