Adjust cartesian point scale and offset types to be numeric instead of distance unit strings

Author: timgrein

docs/reference/query-languages/esql/_snippets/functions/types/decay.md

@@ -97,10 +97,7 @@ public static final class DecayGeoLinear {
         double scaling;
 
         public DecayGeoLinear(String originStr, String scaleStr, String offsetStr, double decay) {
-            this(GeoUtils.parseGeoPoint(originStr, false), scaleStr, offsetStr, decay);
-        }
-
-        public DecayGeoLinear(GeoPoint origin, String scaleStr, String offsetStr, double decay) {
+            GeoPoint origin = GeoUtils.parseGeoPoint(originStr, false);
             double scale = DistanceUnit.DEFAULT.parse(scaleStr, DistanceUnit.DEFAULT);
             this.originLat = origin.lat();
             this.originLon = origin.lon();
@@ -122,10 +119,7 @@ public static final class DecayGeoExp {
         double scaling;
 
         public DecayGeoExp(String originStr, String scaleStr, String offsetStr, double decay) {
-            this(GeoUtils.parseGeoPoint(originStr, false), scaleStr, offsetStr, decay);
-        }
-
-        public DecayGeoExp(GeoPoint origin, String scaleStr, String offsetStr, double decay) {
+            GeoPoint origin = GeoUtils.parseGeoPoint(originStr, false);
             double scale = DistanceUnit.DEFAULT.parse(scaleStr, DistanceUnit.DEFAULT);
             this.originLat = origin.lat();
             this.originLon = origin.lon();
@@ -147,10 +141,7 @@ public static final class DecayGeoGauss {
         double scaling;
 
         public DecayGeoGauss(String originStr, String scaleStr, String offsetStr, double decay) {
-            this(GeoUtils.parseGeoPoint(originStr, false), scaleStr, offsetStr, decay);
-        }
-
-        public DecayGeoGauss(GeoPoint origin, String scaleStr, String offsetStr, double decay) {
+            GeoPoint origin = GeoUtils.parseGeoPoint(originStr, false);
             double scale = DistanceUnit.DEFAULT.parse(scaleStr, DistanceUnit.DEFAULT);
             this.originLat = origin.lat();
             this.originLon = origin.lon();
@@ -243,13 +234,6 @@ public DecayDateLinear(String originStr, String scaleStr, String offsetStr, doub
             this.scaling = scale / (1.0 - decay);
         }
 
-        public DecayDateLinear(long origin, TemporalAmount scale, TemporalAmount offset, double decay) {
-            this.origin = origin;
-            long scaleMillis = temporalAmountToMillis(scale);
-            this.offset = temporalAmountToMillis(offset);
-            this.scaling = scaleMillis / (1.0 - decay);
-        }
-
         public double decayDateLinear(ZonedDateTime docValueDate) {
             long docValue = docValueDate.toInstant().toEpochMilli();
             // as java.lang.Math#abs(long) is a forbidden API, have to use this comparison instead
@@ -273,13 +257,6 @@ public DecayDateExp(String originStr, String scaleStr, String offsetStr, double
             this.scaling = Math.log(decay) / scale;
         }
 
-        public DecayDateExp(long origin, TemporalAmount scale, TemporalAmount offset, double decay) {
-            this.origin = origin;
-            long scaleMillis = temporalAmountToMillis(scale);
-            this.offset = temporalAmountToMillis(offset);
-            this.scaling = Math.log(decay) / scaleMillis;
-        }
-
         public double decayDateExp(ZonedDateTime docValueDate) {
             long docValue = docValueDate.toInstant().toEpochMilli();
             long diff = (docValue >= origin) ? (docValue - origin) : (origin - docValue);
@@ -302,13 +279,6 @@ public DecayDateGauss(String originStr, String scaleStr, String offsetStr, doubl
             this.scaling = 0.5 * Math.pow(scale, 2.0) / Math.log(decay);
         }
 
-        public DecayDateGauss(long origin, TemporalAmount scale, TemporalAmount offset, double decay) {
-            this.origin = origin;
-            long scaleMillis = temporalAmountToMillis(scale);
-            this.offset = temporalAmountToMillis(offset);
-            this.scaling = 0.5 * Math.pow(scaleMillis, 2.0) / Math.log(decay);
-        }
-
         public double decayDateGauss(ZonedDateTime docValueDate) {
             long docValue = docValueDate.toInstant().toEpochMilli();
             long diff = (docValue >= origin) ? (docValue - origin) : (origin - docValue);

docs/reference/query-languages/esql/kibana/definition/functions/decay.json

@@ -104,8 +104,8 @@ decay_result:double
 
 cartesianPointLinear1
 
-ROW value = TO_CARTESIANPOINT("POINT(5 5)"), origin = TO_CARTESIANPOINT("POINT(0 0)"), scale = "10m"
-| EVAL decay_result = decay(value, origin, scale, "0m", 0.25, "linear") 
+ROW value = TO_CARTESIANPOINT("POINT(5 5)"), origin = TO_CARTESIANPOINT("POINT(0 0)"), scale = 10.0
+| EVAL decay_result = decay(value, origin, scale, 0.0, 0.25, "linear") 
 | KEEP decay_result;
 
 decay_result:double
@@ -114,8 +114,8 @@ decay_result:double
 
 cartesianPointLinear2
 
-ROW value = TO_CARTESIANPOINT("POINT(10 0)"), origin = TO_CARTESIANPOINT("POINT(0 0)"), scale = "10m"
-| EVAL decay_result = ROUND(decay(value, origin, scale, "0m", 0.25, "linear"), 10) 
+ROW value = TO_CARTESIANPOINT("POINT(10 0)"), origin = TO_CARTESIANPOINT("POINT(0 0)"), scale = 10.0
+| EVAL decay_result = ROUND(decay(value, origin, scale, 0.0, 0.25, "linear"), 10) 
 | KEEP decay_result;
 
 decay_result:double
@@ -124,8 +124,8 @@ decay_result:double
 
 cartesianPointLinearWithOffset
 
-ROW value = TO_CARTESIANPOINT("POINT(10 0)"), origin = TO_CARTESIANPOINT("POINT(0 0)"), scale = "10m"
-| EVAL decay_result = ROUND(decay(value, origin, scale, "5m", 0.25, "linear"), 10) 
+ROW value = TO_CARTESIANPOINT("POINT(10 0)"), origin = TO_CARTESIANPOINT("POINT(0 0)"), scale = 10.0
+| EVAL decay_result = ROUND(decay(value, origin, scale, 5.0, 0.25, "linear"), 10) 
 | KEEP decay_result;
 
 decay_result:double