Skip to content

Commit 5986166

Browse files
committed
fixup!
1 parent 6546ba4 commit 5986166

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

server/src/main/java/org/elasticsearch/action/admin/cluster/snapshots/restore/RestoreSnapshotRequest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ public ActionRequestValidationException validate() {
132132
if (indicesOptions == null) {
133133
validationException = addValidationError("indicesOptions is missing", validationException);
134134
}
135-
// TODO should additional validation be done here to make sure views are not attempted to be restored?
136135
// This action does not use the IndexNameExpressionResolver to resolve concrete indices, this is why we check here for selectors
137136
if (indicesOptions.allowSelectors() == false) {
138137
for (String index : indices) {

server/src/test/java/org/elasticsearch/action/admin/cluster/snapshots/restore/RestoreSnapshotRequestTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
import java.util.Map;
3131

3232
import static org.hamcrest.Matchers.containsString;
33-
import static org.junit.Assert.assertFalse;
34-
import static org.junit.Assert.assertNotNull;
3533

3634
public class RestoreSnapshotRequestTests extends AbstractWireSerializingTestCase<RestoreSnapshotRequest> {
3735
private RestoreSnapshotRequest randomState(RestoreSnapshotRequest instance) {
@@ -90,7 +88,7 @@ private RestoreSnapshotRequest randomState(RestoreSnapshotRequest instance) {
9088
randomBoolean(),
9189
instance.indicesOptions().ignoreAliases() == false,
9290
randomBoolean(),
93-
false // Restoring views is not supported
91+
false // Specifying views in the restore snapshot request is not supported
9492
)
9593
)
9694
.gatekeeperOptions(IndicesOptions.GatekeeperOptions.builder().allowSelectors(false).includeFailureIndices(true).build())

0 commit comments

Comments
 (0)