Skip to content

Commit 5a76ba5

Browse files
authored
Remove the unused executor builder for vector tile plugin (#96577)
It is a left over from the original development of this end point and not used anywhere.
1 parent ba97cb7 commit 5a76ba5

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed

docs/changelog/96577.yaml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
pr: 96577
2+
summary: Remove the unused executor builder for vector tile plugin
3+
area: Geo
4+
type: breaking
5+
issues: []
6+
breaking:
7+
title: Remove the unused executor builder for vector tile plugin
8+
area: Cluster and node setting
9+
details: "The threadpool called `vectortile` is a left over from the original development of the\
10+
\ vector tile search end point and it is used nowhere. It can still be a breaking change\
11+
\ if it is configured on the elasticsearch yml file, for example by changing the threadpool\
12+
\ size `thread_pool.vectortile.size=8`'"
13+
impact: "In the case the threadpool appears on the yaml file, Elasticsearch will not start until those\
14+
\ lines are removed."
15+
notable: false

x-pack/plugin/vector-tile/src/main/java/org/elasticsearch/xpack/vectortile/VectorTilePlugin.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,9 @@
1717
import org.elasticsearch.plugins.Plugin;
1818
import org.elasticsearch.rest.RestController;
1919
import org.elasticsearch.rest.RestHandler;
20-
import org.elasticsearch.threadpool.ExecutorBuilder;
21-
import org.elasticsearch.threadpool.FixedExecutorBuilder;
2220
import org.elasticsearch.xpack.core.XPackPlugin;
2321
import org.elasticsearch.xpack.vectortile.rest.RestVectorTileAction;
2422

25-
import java.util.Collections;
2623
import java.util.List;
2724
import java.util.function.Supplier;
2825

@@ -45,17 +42,4 @@ public List<RestHandler> getRestHandlers(
4542
) {
4643
return List.of(new RestVectorTileAction());
4744
}
48-
49-
@Override
50-
public List<ExecutorBuilder<?>> getExecutorBuilders(Settings settings) {
51-
FixedExecutorBuilder indexing = new FixedExecutorBuilder(
52-
settings,
53-
"vector_tile_generation",
54-
1,
55-
-1,
56-
"thread_pool.vectortile",
57-
false
58-
);
59-
return Collections.singletonList(indexing);
60-
}
6145
}

0 commit comments

Comments
 (0)