Skip to content

Commit 5d290c9

Browse files
authored
Round sinh result in spec tests (#141403) (#141465)
Some sinh tests are failing on JDK 26 due to increased precision. This change relaxes the tests by rounding and verifying results to 10 decimal places only. Closes #141396
1 parent b08716e commit 5d290c9

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

docs/reference/query-languages/esql/_snippets/functions/examples/sinh.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/qa/testFixtures/src/main/resources/floats.csv-spec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,11 +328,12 @@ sinh
328328
ROW a=1.8
329329
| EVAL sinh=SINH(a)
330330
// end::sinh[]
331+
| EVAL sinh=round(sinh, 10)
331332
;
332333

333334
// tag::sinh-result[]
334335
a:double | sinh:double
335-
1.8 | 2.94217428809568
336+
1.8 | 2.9421742881
336337
// end::sinh-result[]
337338
;
338339

x-pack/plugin/esql/qa/testFixtures/src/main/resources/ints.csv-spec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -939,10 +939,10 @@ a:integer | sin:double
939939
;
940940

941941
sinh
942-
ROW a=2 | EVAL sinh=SINH(a);
942+
ROW a=2 | EVAL sinh=round(SINH(a), 10);
943943

944944
a:integer | sinh:double
945-
2 | 3.626860407847019
945+
2 | 3.6268604078
946946
;
947947

948948
asin

0 commit comments

Comments
 (0)