Fix mutateInstance() in several tests (#136414)

Relates #134166

This addresses misuse of `randomValueOtherThan()` in all the offending
tests in the following packages:

  - elasticsearch.server
  - elasticsearch.x-pack.plugin.autoscaling
  - elasticsearch.x-pack.plugin.core

Author: dimitris-athanasiou

server/src/main/java/org/elasticsearch/action/synonyms/AbstractSynonymsPagedResultAction.java

@@ -182,6 +182,10 @@ public int hashCode() {
             result = 31 * result + Arrays.hashCode(resultList);
             return result;
         }
+
+        PagedResult<? extends Writeable> getResults() {
+            return new PagedResult<>(totalCount, resultList);
+        }
     }
 
 }

server/src/main/java/org/elasticsearch/action/synonyms/DeleteSynonymRuleAction.java

@@ -95,12 +95,14 @@ public boolean equals(Object o) {
             if (this == o) return true;
             if (o == null || getClass() != o.getClass()) return false;
             Request request = (Request) o;
-            return Objects.equals(synonymsSetId, request.synonymsSetId) && Objects.equals(synonymRuleId, request.synonymRuleId);
+            return Objects.equals(synonymsSetId, request.synonymsSetId)
+                && Objects.equals(synonymRuleId, request.synonymRuleId)
+                && refresh == request.refresh;
         }
 
         @Override
         public int hashCode() {
-            return Objects.hash(synonymsSetId, synonymRuleId);
+            return Objects.hash(synonymsSetId, synonymRuleId, refresh);
         }
     }
 }

server/src/main/java/org/elasticsearch/action/synonyms/GetSynonymsAction.java

@@ -91,5 +91,11 @@ protected Reader<SynonymRule> reader() {
         protected IntFunction<SynonymRule[]> arraySupplier() {
             return SynonymRule[]::new;
         }
+
+        @SuppressWarnings("unchecked")
+        @Override
+        PagedResult<SynonymRule> getResults() {
+            return (PagedResult<SynonymRule>) super.getResults();
+        }
     }
 }

server/src/main/java/org/elasticsearch/action/synonyms/GetSynonymsSetsAction.java

@@ -61,6 +61,12 @@ protected Reader<SynonymSetSummary> reader() {
         protected IntFunction<SynonymSetSummary[]> arraySupplier() {
             return SynonymSetSummary[]::new;
         }
+
+        @SuppressWarnings("unchecked")
+        @Override
+        PagedResult<SynonymSetSummary> getResults() {
+            return (PagedResult<SynonymSetSummary>) super.getResults();
+        }
     }
 
 }

server/src/test/java/org/elasticsearch/action/admin/indices/rollover/RolloverConfigurationTests.java

@@ -49,10 +49,16 @@ protected Writeable.Reader<RolloverConfiguration> instanceReader() {
 
     @Override
     protected RolloverConfiguration createTestInstance() {
-        return randomRolloverConditions();
+        return randomRolloverConfiguration();
     }
 
-    public static RolloverConfiguration randomRolloverConditions() {
+    public static RolloverConfiguration randomRolloverConfiguration() {
+        RolloverConditions.Builder concreteConditionsBuilder = randomRolloverConditionsWithoutMaxAgeBuilder();
+        Set<String> automaticConditions = randomAutomaticConditions(concreteConditionsBuilder);
+        return new RolloverConfiguration(concreteConditionsBuilder.build(), automaticConditions);
+    }
+
+    private static RolloverConditions.Builder randomRolloverConditionsWithoutMaxAgeBuilder() {
         ByteSizeValue maxSize = randomBoolean() ? randomByteSizeValue() : null;
         ByteSizeValue maxPrimaryShardSize = randomBoolean() ? randomByteSizeValue() : null;
         Long maxDocs = randomBoolean() ? randomNonNegativeLong() : null;
@@ -63,7 +69,7 @@ public static RolloverConfiguration randomRolloverConditions() {
         TimeValue minAge = randomBoolean() ? randomPositiveTimeValue() : null;
         Long minPrimaryShardDocs = randomBoolean() ? randomNonNegativeLong() : null;
 
-        RolloverConditions.Builder concreteConditionsBuilder = RolloverConditions.newBuilder()
+        return RolloverConditions.newBuilder()
             .addMaxIndexSizeCondition(maxSize)
             .addMaxPrimaryShardSizeCondition(maxPrimaryShardSize)
             .addMaxIndexDocsCondition(maxDocs)
@@ -73,20 +79,31 @@ public static RolloverConfiguration randomRolloverConditions() {
             .addMinIndexAgeCondition(minAge)
             .addMinIndexDocsCondition(minDocs)
             .addMinPrimaryShardDocsCondition(minPrimaryShardDocs);
+    }
+
+    private static Set<String> randomAutomaticConditions(RolloverConditions.Builder conditionsBuilder) {
         Set<String> automaticConditions = new HashSet<>();
         if (randomBoolean()) {
             if (randomBoolean()) {
-                concreteConditionsBuilder.addMaxIndexAgeCondition(TimeValue.timeValueMillis(randomMillisUpToYear9999()));
+                conditionsBuilder.addMaxIndexAgeCondition(TimeValue.timeValueMillis(randomMillisUpToYear9999()));
             } else {
                 automaticConditions.add(MaxAgeCondition.NAME);
             }
         }
-        return new RolloverConfiguration(concreteConditionsBuilder.build(), automaticConditions);
+        return automaticConditions;
     }
 
     @Override
     protected RolloverConfiguration mutateInstance(RolloverConfiguration instance) {
-        return randomValueOtherThan(instance, RolloverConfigurationTests::randomRolloverConditions);
+        RolloverConditions originalConditions = instance.getConcreteConditions();
+        RolloverConditions newConditions = randomValueOtherThan(
+            originalConditions,
+            () -> RolloverConfigurationTests.randomRolloverConditionsWithoutMaxAgeBuilder().build()
+        );
+        // There is no point mutating automatic conditions. If they change, then the concrete conditions
+        // should also change to produce a valid configuration Consequently, the mutated instance is guaranteed to be
+        // different from the original instance and the test purpose would be voided.
+        return new RolloverConfiguration(newConditions, instance.getAutomaticConditions());
     }
 
     public void testConstructorValidation() {
@@ -277,7 +294,7 @@ public void testAutoMaxAgeCalculation() {
 
     public void testToXContent() throws IOException {
         try (XContentBuilder builder = XContentFactory.jsonBuilder().prettyPrint()) {
-            RolloverConfiguration rolloverConfiguration = randomRolloverConditions();
+            RolloverConfiguration rolloverConfiguration = randomRolloverConfiguration();
             rolloverConfiguration.toXContent(builder, EMPTY_PARAMS);
             Map<String, Object> xContentMap = XContentHelper.convertToMap(BytesReference.bytes(builder), false, builder.contentType()).v2();
             RolloverConditions concreteConditions = rolloverConfiguration.getConcreteConditions();

server/src/test/java/org/elasticsearch/action/admin/indices/template/get/GetComponentTemplateResponseTests.java

@@ -62,7 +62,7 @@ public void testXContentSerializationWithRolloverAndEffectiveRetention() throws
             null,
             null
         );
-        var rolloverConfiguration = RolloverConfigurationTests.randomRolloverConditions();
+        var rolloverConfiguration = RolloverConfigurationTests.randomRolloverConfiguration();
         var response = new GetComponentTemplateAction.Response(Map.of(randomAlphaOfLength(10), template), rolloverConfiguration);
 
         try (XContentBuilder builder = XContentBuilder.builder(XContentType.JSON.xContent())) {

server/src/test/java/org/elasticsearch/action/admin/indices/template/put/PutComposableIndexTemplateRequestTests.java

@@ -45,7 +45,18 @@ protected TransportPutComposableIndexTemplateAction.Request createTestInstance()
 
     @Override
     protected TransportPutComposableIndexTemplateAction.Request mutateInstance(TransportPutComposableIndexTemplateAction.Request instance) {
-        return randomValueOtherThan(instance, this::createTestInstance);
+        String name = instance.name();
+        String cause = instance.cause();
+        boolean create = instance.create();
+        ComposableIndexTemplate indexTemplate = instance.indexTemplate();
+        switch (between(0, 3)) {
+            case 0 -> name = randomValueOtherThan(name, () -> randomAlphaOfLength(4));
+            case 1 -> cause = randomValueOtherThan(cause, () -> randomAlphaOfLength(4));
+            case 2 -> create = create == false;
+            case 3 -> indexTemplate = ComposableIndexTemplateTests.randomInstance();
+            default -> throw new AssertionError("Illegal randomisation branch");
+        }
+        return new TransportPutComposableIndexTemplateAction.Request(name).cause(cause).create(create).indexTemplate(indexTemplate);
     }
 
     public void testPutGlobalTemplatesCannotHaveHiddenIndexSetting() {

server/src/test/java/org/elasticsearch/action/synonyms/DeleteSynonymRuleActionRequestSerializingTests.java

@@ -28,6 +28,15 @@ protected DeleteSynonymRuleAction.Request createTestInstance() {
 
     @Override
     protected DeleteSynonymRuleAction.Request mutateInstance(DeleteSynonymRuleAction.Request instance) throws IOException {
-        return randomValueOtherThan(instance, this::createTestInstance);
+        String synonymsSetId = instance.synonymsSetId();
+        String synonymRuleId = instance.synonymRuleId();
+        boolean refresh = instance.refresh();
+        switch (between(0, 2)) {
+            case 0 -> synonymsSetId = randomValueOtherThan(synonymsSetId, () -> randomIdentifier());
+            case 1 -> synonymRuleId = randomValueOtherThan(synonymRuleId, () -> randomIdentifier());
+            case 2 -> refresh = refresh == false;
+            default -> throw new AssertionError("Illegal randomisation branch");
+        }
+        return new DeleteSynonymRuleAction.Request(synonymsSetId, synonymRuleId, refresh);
     }
 }

server/src/test/java/org/elasticsearch/action/synonyms/GetSynonymRuleActionRequestSerializingTests.java

@@ -28,6 +28,13 @@ protected GetSynonymRuleAction.Request createTestInstance() {
 
     @Override
     protected GetSynonymRuleAction.Request mutateInstance(GetSynonymRuleAction.Request instance) throws IOException {
-        return randomValueOtherThan(instance, this::createTestInstance);
+        String synonymsSetId = instance.synonymsSetId();
+        String synonymRuleId = instance.synonymRuleId();
+        switch (between(0, 1)) {
+            case 0 -> synonymsSetId = randomValueOtherThan(synonymsSetId, () -> randomIdentifier());
+            case 1 -> synonymRuleId = randomValueOtherThan(synonymRuleId, () -> randomIdentifier());
+            default -> throw new AssertionError("Illegal randomisation branch");
+        }
+        return new GetSynonymRuleAction.Request(synonymsSetId, synonymRuleId);
     }
 }

server/src/test/java/org/elasticsearch/action/synonyms/GetSynonymsActionRequestSerializingTests.java

@@ -32,6 +32,15 @@ protected GetSynonymsAction.Request createTestInstance() {
 
     @Override
     protected GetSynonymsAction.Request mutateInstance(GetSynonymsAction.Request instance) throws IOException {
-        return randomValueOtherThan(instance, this::createTestInstance);
+        String synonymsSetId = instance.synonymsSetId();
+        int from = instance.from();
+        int size = instance.size();
+        switch (between(0, 2)) {
+            case 0 -> synonymsSetId = randomValueOtherThan(synonymsSetId, () -> randomIdentifier());
+            case 1 -> from = randomValueOtherThan(from, () -> randomIntBetween(0, Integer.MAX_VALUE));
+            case 2 -> size = randomValueOtherThan(size, () -> randomIntBetween(0, Integer.MAX_VALUE));
+            default -> throw new AssertionError("Illegal randomisation branch");
+        }
+        return new GetSynonymsAction.Request(synonymsSetId, from, size);
     }
 }