Skip to content

Commit 5f10da6

Browse files
committed
Minor DocValuesDocReader cleanup
The instance members can be private, all final, and SearchLookup is unused.
1 parent 238b279 commit 5f10da6

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

server/src/main/java/org/elasticsearch/script/DocValuesDocReader.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,15 @@
2525
/**
2626
* Provide access to DocValues for script {@code field} api and {@code doc} API.
2727
*/
28-
public class DocValuesDocReader implements DocReader, LeafReaderContextSupplier {
29-
30-
protected final SearchLookup searchLookup;
28+
public final class DocValuesDocReader implements DocReader, LeafReaderContextSupplier {
3129

3230
// provide access to the leaf context reader for expressions
33-
protected final LeafReaderContext leafReaderContext;
31+
private final LeafReaderContext leafReaderContext;
3432

3533
/** A leaf lookup for the bound segment this proxy will operate on. */
36-
protected LeafSearchLookup leafSearchLookup;
34+
private final LeafSearchLookup leafSearchLookup;
3735

3836
public DocValuesDocReader(SearchLookup searchLookup, LeafReaderContext leafContext) {
39-
this.searchLookup = searchLookup;
4037
this.leafReaderContext = leafContext;
4138
this.leafSearchLookup = searchLookup.getLeafSearchLookup(leafReaderContext);
4239
}

0 commit comments

Comments
 (0)