Skip to content

Commit 5fa0786

Browse files
committed
Support serialization of aggregate metric double literal
1 parent 1d1feb6 commit 5fa0786

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

server/src/main/java/org/elasticsearch/common/io/stream/StreamOutput.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
import java.util.function.IntFunction;
5151

5252
import static java.util.Map.entry;
53-
import static org.elasticsearch.TransportVersions.V_8_11_X;
5453

5554
/**
5655
* A stream from another node to this node. Technically, it can also be streamed from a byte array but that is mostly for testing.
@@ -813,13 +812,10 @@ public final void writeOptionalInstant(@Nullable Instant instant) throws IOExcep
813812
entry(GenericNamedWriteable.class, (o, v) -> {
814813
// Note that we do not rely on the checks in VersionCheckingStreamOutput because that only applies to CCS
815814
final var genericNamedWriteable = (GenericNamedWriteable) v;
816-
TransportVersion minSupportedVersion = genericNamedWriteable.getMinimalSupportedVersion();
817-
assert minSupportedVersion.onOrAfter(V_8_11_X) : "[GenericNamedWriteable] requires [" + V_8_11_X + "]";
818-
if (o.getTransportVersion().before(minSupportedVersion)) {
815+
if (genericNamedWriteable.supportsVersion(o.getTransportVersion()) == false) {
819816
final var message = Strings.format(
820-
"[%s] requires minimal transport version [%s] and cannot be sent using transport version [%s]",
817+
"[%s] doesn't support serialization with transport version [%s]",
821818
genericNamedWriteable.getWriteableName(),
822-
minSupportedVersion,
823819
o.getTransportVersion()
824820
);
825821
assert false : message;

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/data/AggregateMetricDoubleBlockBuilder.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,14 @@ public void writeTo(StreamOutput out) throws IOException {
200200
}
201201

202202
@Override
203-
public TransportVersion getMinimalSupportedVersion() {
204-
return TransportVersions.ESQL_AGGREGATE_METRIC_DOUBLE_LITERAL;
203+
public boolean supportsVersion(TransportVersion version) {
204+
return version.onOrAfter(TransportVersions.ESQL_AGGREGATE_METRIC_DOUBLE_LITERAL);
205205
}
206206

207+
@Override
208+
public TransportVersion getMinimalSupportedVersion() {
209+
assert false : "must not be called when overriding supportsVersion";
210+
throw new UnsupportedOperationException("must not be called when overriding supportsVersion");
211+
}
207212
}
208213
}

0 commit comments

Comments
 (0)