Implement TODO UTF8 to UTF16 conversion

jordan-powers · jordan-powers · commit 603af45538b8 · 2025-04-28T15:34:24.000-07:00
diff --git a/libs/core/src/main/java/org/elasticsearch/core/BaseText.java b/libs/core/src/main/java/org/elasticsearch/core/BaseText.java
@@ -12,6 +12,7 @@
 import org.elasticsearch.core.bytes.BaseBytesArray;
 import org.elasticsearch.core.bytes.BaseBytesReference;
 
+import java.nio.ByteBuffer;
 import java.nio.charset.StandardCharsets;
 
 /**
@@ -65,7 +66,7 @@ public boolean hasString() {
      */
     public String string() {
         if (text == null) {
-            throw new UnsupportedOperationException("TODO");
+            text = StandardCharsets.UTF_8.decode(ByteBuffer.wrap(bytes.array(), bytes.arrayOffset(), bytes.length())).toString();
         }
         return text;
     }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`import org.elasticsearch.core.bytes.BaseBytesArray;`
`13`	`13`	`import org.elasticsearch.core.bytes.BaseBytesReference;`
`14`	`14`
	`15`	`+import java.nio.ByteBuffer;`
`15`	`16`	`import java.nio.charset.StandardCharsets;`
`16`	`17`
`17`	`18`	`/**`
`@@ -65,7 +66,7 @@ public boolean hasString() {`
`65`	`66`	`*/`
`66`	`67`	`public String string() {`
`67`	`68`	`if (text == null) {`
`68`		`- throw new UnsupportedOperationException("TODO");`
	`69`	`+ text = StandardCharsets.UTF_8.decode(ByteBuffer.wrap(bytes.array(), bytes.arrayOffset(), bytes.length())).toString();`
`69`	`70`	`}`
`70`	`71`	`return text;`
`71`	`72`	`}`