Skip to content

Commit 607265b

Browse files
committed
ESQL: Reenable heap attacks
Reenables some heap attack tests, bumping their memory requirements to try and force a failure on all CI machines. Previously some CI machines weren't failing, invalidating the test on those machines.
1 parent 92d1d31 commit 607265b

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

muted-tests.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -387,9 +387,6 @@ tests:
387387
- class: org.elasticsearch.xpack.ml.integration.ClassificationIT
388388
method: testDependentVariableIsAliasToNested
389389
issue: https://github.com/elastic/elasticsearch/issues/121415
390-
- class: org.elasticsearch.xpack.esql.heap_attack.HeapAttackIT
391-
method: testLookupExplosionBigStringManyMatches
392-
issue: https://github.com/elastic/elasticsearch/issues/121465
393390
- class: org.elasticsearch.xpack.security.authc.jwt.JwtRealmSingleNodeTests
394391
method: testClientSecretRotation
395392
issue: https://github.com/elastic/elasticsearch/issues/120985
@@ -399,9 +396,6 @@ tests:
399396
- class: org.elasticsearch.xpack.security.CoreWithSecurityClientYamlTestSuiteIT
400397
method: test {yaml=cluster.health/10_basic/cluster health basic test}
401398
issue: https://github.com/elastic/elasticsearch/issues/121478
402-
- class: org.elasticsearch.xpack.esql.heap_attack.HeapAttackIT
403-
method: testLookupExplosionManyMatches
404-
issue: https://github.com/elastic/elasticsearch/issues/121481
405399
- class: org.elasticsearch.xpack.security.profile.ProfileIntegTests
406400
method: testGetUsersWithProfileUid
407401
issue: https://github.com/elastic/elasticsearch/issues/121483

test/external-modules/esql-heap-attack/src/javaRestTest/java/org/elasticsearch/xpack/esql/heap_attack/HeapAttackIT.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,8 @@ public void testLookupExplosion() throws IOException {
636636

637637
public void testLookupExplosionManyMatches() throws IOException {
638638
assertCircuitBreaks(() -> {
639-
Map<?, ?> result = lookupExplosion(1500, 10000);
639+
// 1500, 10000 is enough locally, but some CI machines need more.
640+
Map<?, ?> result = lookupExplosion(2000, 10000);
640641
logger.error("should have failed but got {}", result);
641642
});
642643
}
@@ -664,7 +665,8 @@ public void testLookupExplosionBigString() throws IOException {
664665

665666
public void testLookupExplosionBigStringManyMatches() throws IOException {
666667
assertCircuitBreaks(() -> {
667-
Map<?, ?> result = lookupExplosionBigString(500, 1);
668+
// 500, 1 is enough to make it fail locally but some CI needs more
669+
Map<?, ?> result = lookupExplosionBigString(800, 1);
668670
logger.error("should have failed but got {}", result);
669671
});
670672
}

0 commit comments

Comments
 (0)