Skip to content

Commit 609b42c

Browse files
Merge branch 'main' into dense_vector_stats
2 parents a7c50c8 + 7350e36 commit 609b42c

File tree

27 files changed

+658
-240
lines changed

27 files changed

+658
-240
lines changed

.buildkite/pipelines/intake.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ steps:
5656
timeout_in_minutes: 300
5757
matrix:
5858
setup:
59-
BWC_VERSION: ["8.17.6", "8.18.0", "8.19.0", "9.0.0", "9.1.0"]
59+
BWC_VERSION: ["8.17.6", "8.18.0", "8.19.0", "9.0.1", "9.1.0"]
6060
agents:
6161
provider: gcp
6262
image: family/elasticsearch-ubuntu-2004

.buildkite/pipelines/periodic-packaging.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,8 @@ steps:
351351
env:
352352
BWC_VERSION: 8.19.0
353353

354-
- label: "{{matrix.image}} / 9.0.0 / packaging-tests-upgrade"
355-
command: ./.ci/scripts/packaging-test.sh -Dbwc.checkout.align=true destructiveDistroUpgradeTest.v9.0.0
354+
- label: "{{matrix.image}} / 9.0.1 / packaging-tests-upgrade"
355+
command: ./.ci/scripts/packaging-test.sh -Dbwc.checkout.align=true destructiveDistroUpgradeTest.v9.0.1
356356
timeout_in_minutes: 300
357357
matrix:
358358
setup:
@@ -365,7 +365,7 @@ steps:
365365
machineType: custom-16-32768
366366
buildDirectory: /dev/shm/bk
367367
env:
368-
BWC_VERSION: 9.0.0
368+
BWC_VERSION: 9.0.1
369369

370370
- label: "{{matrix.image}} / 9.1.0 / packaging-tests-upgrade"
371371
command: ./.ci/scripts/packaging-test.sh -Dbwc.checkout.align=true destructiveDistroUpgradeTest.v9.1.0

.buildkite/pipelines/periodic.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -382,8 +382,8 @@ steps:
382382
- signal_reason: agent_stop
383383
limit: 3
384384

385-
- label: 9.0.0 / bwc
386-
command: .ci/scripts/run-gradle.sh -Dbwc.checkout.align=true v9.0.0#bwcTest
385+
- label: 9.0.1 / bwc
386+
command: .ci/scripts/run-gradle.sh -Dbwc.checkout.align=true v9.0.1#bwcTest
387387
timeout_in_minutes: 300
388388
agents:
389389
provider: gcp
@@ -392,7 +392,7 @@ steps:
392392
buildDirectory: /dev/shm/bk
393393
preemptible: true
394394
env:
395-
BWC_VERSION: 9.0.0
395+
BWC_VERSION: 9.0.1
396396
retry:
397397
automatic:
398398
- exit_status: "-1"
@@ -486,7 +486,7 @@ steps:
486486
setup:
487487
ES_RUNTIME_JAVA:
488488
- openjdk21
489-
BWC_VERSION: ["8.17.6", "8.18.0", "8.19.0", "9.0.0", "9.1.0"]
489+
BWC_VERSION: ["8.17.6", "8.18.0", "8.19.0", "9.0.1", "9.1.0"]
490490
agents:
491491
provider: gcp
492492
image: family/elasticsearch-ubuntu-2004
@@ -533,7 +533,7 @@ steps:
533533
ES_RUNTIME_JAVA:
534534
- openjdk21
535535
- openjdk23
536-
BWC_VERSION: ["8.17.6", "8.18.0", "8.19.0", "9.0.0", "9.1.0"]
536+
BWC_VERSION: ["8.17.6", "8.18.0", "8.19.0", "9.0.1", "9.1.0"]
537537
agents:
538538
provider: gcp
539539
image: family/elasticsearch-ubuntu-2004

.ci/bwcVersions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ BWC_VERSION:
1919
- "8.17.6"
2020
- "8.18.0"
2121
- "8.19.0"
22-
- "9.0.0"
22+
- "9.0.1"
2323
- "9.1.0"

.ci/snapshotBwcVersions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ BWC_VERSION:
22
- "8.17.6"
33
- "8.18.0"
44
- "8.19.0"
5-
- "9.0.0"
5+
- "9.0.1"
66
- "9.1.0"

docs/changelog/126803.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
pr: 126803
2+
summary: "[Security Solution] Add `read` index privileges to `kibana_system` role\
3+
\ for Microsoft Defender integration indexes"
4+
area: Authorization
5+
type: enhancement
6+
issues: []

docs/changelog/126806.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
pr: 126806
2+
summary: Workaround max name limit imposed by Jackson 2.17
3+
area: Infra/Core
4+
type: bug
5+
issues: []

libs/entitlement/src/main/java/org/elasticsearch/entitlement/initialization/EntitlementInitialization.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,15 +230,13 @@ private static PolicyManager createPolicyManager() {
230230
new ReadStoreAttributesEntitlement(),
231231
new CreateClassLoaderEntitlement(),
232232
new InboundNetworkEntitlement(),
233-
new OutboundNetworkEntitlement(),
234233
new LoadNativeLibrariesEntitlement(),
235234
new ManageThreadsEntitlement(),
236235
new FilesEntitlement(serverModuleFileDatas)
237236
)
238237
),
239238
new Scope("java.desktop", List.of(new LoadNativeLibrariesEntitlement())),
240239
new Scope("org.apache.httpcomponents.httpclient", List.of(new OutboundNetworkEntitlement())),
241-
new Scope("io.netty.transport", List.of(new InboundNetworkEntitlement(), new OutboundNetworkEntitlement())),
242240
new Scope(
243241
"org.apache.lucene.core",
244242
List.of(

libs/x-content/impl/src/main/java/org/elasticsearch/xcontent/provider/XContentImplUtils.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ public class XContentImplUtils {
1717
public static <F extends JsonFactory, B extends TSFBuilder<F, B>> F configure(TSFBuilder<F, B> builder) {
1818
// jackson 2.15 introduced a max string length. We have other limits in place to constrain max doc size,
1919
// so here we set to max value (2GiB) so as not to constrain further than those existing limits.
20-
return builder.streamReadConstraints(StreamReadConstraints.builder().maxStringLength(Integer.MAX_VALUE).build()).build();
20+
// jackson 2.16 further introduced a max name length, which we also relax here temporarily.
21+
// see https://github.com/elastic/elasticsearch/issues/58952
22+
return builder.streamReadConstraints(
23+
StreamReadConstraints.builder().maxStringLength(Integer.MAX_VALUE).maxNameLength(Integer.MAX_VALUE).build()
24+
).build();
2125
}
2226
}

modules/repository-gcs/src/test/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageBlobContainerRetriesTests.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
import fixture.gcs.FakeOAuth2HttpHandler;
1212
import fixture.gcs.GoogleCloudStorageHttpHandler;
13+
import fixture.gcs.MultipartUpload;
1314

1415
import com.google.api.client.http.HttpExecuteInterceptor;
1516
import com.google.api.client.http.HttpRequestInitializer;
@@ -43,7 +44,6 @@
4344
import org.elasticsearch.core.Nullable;
4445
import org.elasticsearch.core.SuppressForbidden;
4546
import org.elasticsearch.core.TimeValue;
46-
import org.elasticsearch.core.Tuple;
4747
import org.elasticsearch.http.ResponseInjectingHttpHandler;
4848
import org.elasticsearch.repositories.blobstore.AbstractBlobContainerRetriesTestCase;
4949
import org.elasticsearch.repositories.blobstore.ESMockAPIBasedRepositoryIntegTestCase;
@@ -62,15 +62,13 @@
6262
import java.util.Locale;
6363
import java.util.Map;
6464
import java.util.Objects;
65-
import java.util.Optional;
6665
import java.util.Queue;
6766
import java.util.concurrent.ConcurrentHashMap;
6867
import java.util.concurrent.ConcurrentLinkedQueue;
6968
import java.util.concurrent.atomic.AtomicBoolean;
7069
import java.util.concurrent.atomic.AtomicInteger;
7170
import java.util.concurrent.atomic.AtomicReference;
7271

73-
import static fixture.gcs.GoogleCloudStorageHttpHandler.parseMultipartRequestBody;
7472
import static fixture.gcs.TestUtils.createServiceAccount;
7573
import static java.nio.charset.StandardCharsets.UTF_8;
7674
import static org.elasticsearch.repositories.blobstore.BlobStoreTestUtil.randomPurpose;
@@ -80,7 +78,6 @@
8078
import static org.elasticsearch.repositories.gcs.GoogleCloudStorageClientSettings.ENDPOINT_SETTING;
8179
import static org.elasticsearch.repositories.gcs.GoogleCloudStorageClientSettings.READ_TIMEOUT_SETTING;
8280
import static org.elasticsearch.repositories.gcs.GoogleCloudStorageClientSettings.TOKEN_URI_SETTING;
83-
import static org.elasticsearch.test.hamcrest.OptionalMatchers.isPresent;
8481
import static org.hamcrest.Matchers.anyOf;
8582
import static org.hamcrest.Matchers.containsString;
8683
import static org.hamcrest.Matchers.equalTo;
@@ -268,17 +265,16 @@ public void testWriteBlobWithRetries() throws Exception {
268265
final CountDown countDown = new CountDown(maxRetries);
269266

270267
final BlobContainer blobContainer = blobContainerBuilder().maxRetries(maxRetries).build();
271-
final byte[] bytes = randomBlobContent();
268+
final byte[] bytes = randomBlobContent(0);
272269
httpServer.createContext("/upload/storage/v1/b/bucket/o", safeHandler(exchange -> {
273270
assertThat(exchange.getRequestURI().getQuery(), containsString("uploadType=multipart"));
274271
if (countDown.countDown()) {
275-
Optional<Tuple<String, BytesReference>> content = parseMultipartRequestBody(exchange.getRequestBody());
276-
assertThat(content, isPresent());
277-
assertThat(content.get().v1(), equalTo(blobContainer.path().buildAsString() + "write_blob_max_retries"));
278-
if (Objects.deepEquals(bytes, BytesReference.toBytes(content.get().v2()))) {
272+
MultipartUpload multipartUpload = MultipartUpload.parseBody(exchange, exchange.getRequestBody());
273+
assertEquals(multipartUpload.name(), blobContainer.path().buildAsString() + "write_blob_max_retries");
274+
if (multipartUpload.content().equals(new BytesArray(bytes))) {
279275
byte[] response = Strings.format("""
280276
{"bucket":"bucket","name":"%s"}
281-
""", content.get().v1()).getBytes(UTF_8);
277+
""", multipartUpload.name()).getBytes(UTF_8);
282278
exchange.getResponseHeaders().add("Content-Type", "application/json");
283279
exchange.sendResponseHeaders(RestStatus.OK.getStatus(), response.length);
284280
exchange.getResponseBody().write(response);

0 commit comments

Comments
 (0)