Merge branch 'main' into feature/fix-failing-apt-get

Author: ankit--sethi

muted-tests.yml

@@ -529,6 +529,9 @@ tests:
 - class: org.elasticsearch.entitlement.runtime.policy.FileAccessTreeTests
   method: testWindowsAbsolutPathAccess
   issue: https://github.com/elastic/elasticsearch/issues/129168
+- class: org.elasticsearch.xpack.esql.qa.single_node.PushQueriesIT
+  method: testCaseInsensitiveEquality {KEYWORD}
+  issue: https://github.com/elastic/elasticsearch/issues/129422
 
 # Examples:
 #

server/src/test/java/org/elasticsearch/rest/action/RestCancellableNodeClientTests.java

@@ -304,6 +304,11 @@ public void addCloseListener(ActionListener<Void> listener) {
             // if the channel is already closed, the listener gets notified immediately, from the same thread.
             if (open.get() == false) {
                 listener.onResponse(null);
+                // Ensure closeLatch is pulled by completing the closeListener with a noop that is ignored if it is already completed.
+                // Note that when the channel is closed we may see multiple addCloseListener() calls, so we do not assert on isDone() here,
+                // and since closeListener may already be completed we cannot rely on it to complete the current listener, so we first
+                // complete it directly and then pass a noop to closeListener.
+                closeListener.onResponse(ActionListener.assertOnce(ActionListener.noop()));
             } else {
                 assertFalse("close listener already set, only one is allowed!", closeListener.isDone());
                 closeListener.onResponse(ActionListener.assertOnce(listener));