Skip to content

Commit 6124836

Browse files
[8.x] Cannot skip tests named "values" (#115096) (#115111)
* Cannot skip tests named "values" (#115096) When trying to use a gradle `skipTest` rule on tests named "values", we get a class-caste exception in Jackson. This PR needs to rename this function for all versions of Elasticsearch that the `yamlRestCompatTestTransform` task will run on, so that later PRs that add skipTests will be able to pass. Since this test was added in 8.14, we must backport all the way back to there. ``` class com.fasterxml.jackson.databind.node.IntNode cannot be cast to class com.fasterxml.jackson.databind.node.ArrayNode (com.fasterxml.jackson.databind.node.IntNode and com.fasterxml.jackson.databind.node.ArrayNode are in unnamed module of loader org.gradle.internal.classloader.VisitableURLClassLoader$InstrumentingVisitableURLClassLoader @50337c96) ``` * Mutes from main that are needed on 8.x
1 parent 9e7d3a7 commit 6124836

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

muted-tests.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -418,6 +418,18 @@ tests:
418418
- class: org.elasticsearch.compute.aggregation.blockhash.BlockHashRandomizedTests
419419
method: test {forcePackedHash=false groups=1 maxValuesPerPosition=1 dups=2 allowedTypes=[Ordinals[dictionarySize=10]]}
420420
issue: https://github.com/elastic/elasticsearch/issues/115105
421+
- class: org.elasticsearch.index.mapper.TextFieldMapperTests
422+
method: testBlockLoaderFromRowStrideReaderWithSyntheticSource
423+
issue: https://github.com/elastic/elasticsearch/issues/115066
424+
- class: org.elasticsearch.index.mapper.TextFieldMapperTests
425+
method: testBlockLoaderFromColumnReaderWithSyntheticSource
426+
issue: https://github.com/elastic/elasticsearch/issues/115073
427+
- class: org.elasticsearch.index.mapper.annotatedtext.AnnotatedTextFieldMapperTests
428+
method: testBlockLoaderFromColumnReaderWithSyntheticSource
429+
issue: https://github.com/elastic/elasticsearch/issues/115074
430+
- class: org.elasticsearch.index.mapper.annotatedtext.AnnotatedTextFieldMapperTests
431+
method: testBlockLoaderFromRowStrideReaderWithSyntheticSource
432+
issue: https://github.com/elastic/elasticsearch/issues/115076
421433

422434
# Examples:
423435
#

x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/esql/80_text.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,7 @@ setup:
563563
- match: { values.1.0: "Payroll Specialist" }
564564

565565
---
566-
values:
566+
"values function":
567567
- requires:
568568
cluster_features: esql.agg_values
569569
reason: "values is available in 8.14+"

0 commit comments

Comments
 (0)