Some cleanup and verification

Author: breskeby

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/DependenciesInfoPlugin.java

@@ -10,7 +10,6 @@
 package org.elasticsearch.gradle.internal;
 
 import org.elasticsearch.gradle.dependencies.CompileOnlyResolvePlugin;
-import org.elasticsearch.gradle.internal.precommit.DependencyLicensesTask;
 import org.gradle.api.Plugin;
 import org.gradle.api.Project;
 import org.gradle.api.artifacts.Configuration;

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/DependenciesInfoTask.java

@@ -60,6 +60,11 @@ public abstract class DependenciesInfoTask extends ConventionTask {
     @Inject
     public abstract ProviderFactory getProviderFactory();
 
+    /**
+     * We have to use ArtifactCollection instead of ResolvedArtifactResult here as we're running
+     * into a an issue in Gradle: https://github.com/gradle/gradle/issues/27582
+     */
+
     @Internal
     abstract Property<ArtifactCollection> getRuntimeArtifacts();
 
@@ -76,6 +81,11 @@ public Provider<Set<ModuleComponentIdentifier>> getCompileOnlyModules() {
         return mapToModuleComponentIdentifiers(getCompileOnlyArtifacts().get());
     }
 
+    /**
+     * We need to track file inputs here from the configurations we inspect to ensure we dont miss any
+     * artifact transforms that might be applied and fail due to missing task dependency to jar
+     * generating tasks.
+     * */
     @InputFiles
     abstract ConfigurableFileCollection getClasspath();