Use Booleans.parseBoolean(...., false) in case setting is absent

kvanerum · kvanerum · commit 61ac240230b4 · 2025-06-26T18:36:12.000+02:00
diff --git a/qa/lucene-index-compatibility/src/javaRestTest/java/org/elasticsearch/lucene/AbstractIndexCompatibilityTestCase.java b/qa/lucene-index-compatibility/src/javaRestTest/java/org/elasticsearch/lucene/AbstractIndexCompatibilityTestCase.java
@@ -331,7 +331,7 @@ protected static List<ClusterBlock> indexBlocks(String indexName) throws Excepti
     @SuppressWarnings("unchecked")
     protected static void assertIndexSetting(String indexName, Setting<?> setting, Matcher<Boolean> matcher) throws Exception {
         var indexSettings = getIndexSettingsAsMap(indexName);
-        assertThat(Booleans.parseBoolean((String) indexSettings.get(setting.getKey())), matcher);
+        assertThat(Booleans.parseBoolean((String) indexSettings.get(setting.getKey()), false), matcher);
     }
 
     protected static ResponseException expectUpdateIndexSettingsThrows(String indexName, Settings.Builder settings) {

Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,7 @@ protected static List<ClusterBlock> indexBlocks(String indexName) throws Excepti`
`331`	`331`	`@SuppressWarnings("unchecked")`
`332`	`332`	`protected static void assertIndexSetting(String indexName, Setting<?> setting, Matcher<Boolean> matcher) throws Exception {`
`333`	`333`	`var indexSettings = getIndexSettingsAsMap(indexName);`
`334`		`- assertThat(Booleans.parseBoolean((String) indexSettings.get(setting.getKey())), matcher);`
	`334`	`+ assertThat(Booleans.parseBoolean((String) indexSettings.get(setting.getKey()), false), matcher);`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`protected static ResponseException expectUpdateIndexSettingsThrows(String indexName, Settings.Builder settings) {`