cleanup

Author: DiannaHohensee

server/src/internalClusterTest/java/org/elasticsearch/index/shard/IndexShardIT.java

@@ -394,7 +394,6 @@ public void testShardWriteLoadsArePresent() {
                 for (int i = 0; i < indexMetadata.getNumberOfShards(); i++) {
                     final ShardId shardId = new ShardId(indexMetadata.getIndex(), i);
                     assertTrue(shardWriteLoads.containsKey(shardId));
-                    logger.info("~~~shardWriteLoads: " + shardWriteLoads.get(shardId));
                     maximumLoadRecorded = Math.max(shardWriteLoads.get(shardId), maximumLoadRecorded);
                 }
                 // Each index should have seen some write-load

server/src/main/java/org/elasticsearch/cluster/routing/ShardMovementWriteLoadSimulator.java

@@ -80,16 +80,6 @@ public Map<String, NodeUsageStatsForThreadPools> simulatedNodeUsageStatsForThrea
         return Collections.unmodifiableMap(adjustedNodeUsageStatsForThreadPools);
     }
 
-    /**
-     * averageThreadPoolUtilization
-     *    total shard execution time (sum of shard write loads) / total execution time (totalThreadPoolThreads x duration)
-     *    (30 + 20 + 40) / (4 x 30s) = 90 / 120 = .75
-     *
-     * writeLoadDelta / totalThreadPoolThreads
-     * 20 / 4 = 5
-     *
-     */
-
     private static NodeUsageStatsForThreadPools.ThreadPoolUsageStats replaceWritePoolStats(
         NodeUsageStatsForThreadPools value,
         double writeLoadDelta

server/src/main/java/org/elasticsearch/cluster/routing/allocation/decider/WriteLoadConstraintDecider.java

@@ -39,7 +39,7 @@ public WriteLoadConstraintDecider(ClusterSettings clusterSettings) {
 
     @Override
     public Decision canAllocate(ShardRouting shardRouting, RoutingNode node, RoutingAllocation allocation) {
-        if (writeLoadConstraintSettings.getWriteLoadConstraintEnabled() != WriteLoadConstraintSettings.WriteLoadDeciderStatus.ENABLED) {
+        if (writeLoadConstraintSettings.getWriteLoadConstraintEnabled() == WriteLoadConstraintSettings.WriteLoadDeciderStatus.DISABLED) {
             return Decision.single(Decision.Type.YES, NAME, "Decider is disabled");
         }