Skip to content

Commit 635e8dd

Browse files
committed
close properly
1 parent 8ffb7fc commit 635e8dd

File tree

6 files changed

+54
-6
lines changed

6 files changed

+54
-6
lines changed

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/SampleBooleanAggregator.java

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/SampleBytesRefAggregator.java

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/SampleDoubleAggregator.java

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/SampleIntAggregator.java

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/SampleLongAggregator.java

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/X-SampleAggregator.java.st

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,15 @@ class Sample$Type$Aggregator {
131131
private GroupingState(BigArrays bigArrays, int limit) {
132132
CircuitBreaker breaker = bigArrays.breakerService().getBreaker(CircuitBreaker.REQUEST);
133133
this.sort = new BytesRefBucketedSort(breaker, "sample", bigArrays, SortOrder.ASC, limit);
134-
this.bytesRefBuilder = new BreakingBytesRefBuilder(breaker, "sample");
134+
boolean success = false;
135+
try {
136+
this.bytesRefBuilder = new BreakingBytesRefBuilder(breaker, "sample");
137+
success = true;
138+
} finally {
139+
if (success == false) {
140+
Releasables.closeExpectNoException(sort);
141+
}
142+
}
135143
}
136144

137145
public void add(int groupId, $type$ value) {

0 commit comments

Comments
 (0)